Igor Klemenski

Results 76 comments of Igor Klemenski

Thanks, @rolinh, I've squashed the commit and created https://github.com/cilium/cilium/issues/36195 to remove the unsued code.

@rolinh I've rebased on main to resolve a failing lint check coming from yesterday's common labels change: https://github.com/cilium/cilium/pull/35628 Force pushed three times: - squash PR feedback comment (no diff): -...

Re. 2 We need to store the pointer as we are doing now, because the underlying value is not set until the function completes. It is an out-parameter, since the...

@matthew-duval Is this arm64 or amd64? Can you provide the kernel version too?

Can we identify when this regressed? It's a pretty massive functionality bug this PR is addressing

Can you edit the PR description to demonstrate the before/after of the fix,? Currently it only shows that for applying an annotation. For better readability, I'd just include a snippet...