specs icon indicating copy to clipboard operation
specs copied to clipboard

Remove flyout services

Open wetneb opened this issue 5 years ago • 5 comments

Now that the suggest services return descriptions (which was not the case a few years ago), we could consider removing the flyout service which is redundant with these descriptions. Flyout services lead to an awkward user experience where the user must hover a suggest drop-down menu to display the description: image

See related issue in Wikidata recon service: https://github.com/wetneb/openrefine-wikibase/issues/77

wetneb avatar Feb 27 '20 13:02 wetneb

I think that normalizing the two responses would be really helpful--it's a pain to implement both of them, with their subtle differences. Not difficult, but annoying.

workergnome avatar Feb 27 '20 20:02 workergnome

So you would keep the flyout services in the specs, but unify their output to align them with the descriptions in suggest services?

wetneb avatar Feb 27 '20 22:02 wetneb

no--I think resolving them into a single "preview" or "display" service would be the right decision. The current ones are redundant, and are also not implemented the same way, which means you have to code two different systems to display the same data.

workergnome avatar Feb 27 '20 23:02 workergnome

At the moment we have:

  • preview services;
  • suggest services (which can include descriptions in the suggestions they return);
  • flyout services, which return HTML snippets to be displayed next to suggest items.

I propose to remove flyout services altogether - if clients want to display additional previews on results from suggest services, they can use the existing preview service.

I would not try to unify the preview services and the suggested descriptions, since they do not fit the same purpose (preview services return big chunks of HTML, suggested descriptions are short strings of plain text).

wetneb avatar Feb 28 '20 01:02 wetneb

Duplicate of #50, sorry!

wetneb avatar Aug 31 '20 00:08 wetneb