choko

choko copied to clipboard

As for today, when layout is parsing recursively through rows and columns it doesn't mind printing markup for regions that don't have content. This pull request changes that by recursively identifying empty regions (row/columns). It also introduces a region attribute called alwaysVisible that when set to true will cause a region wrapper to be output even when it has no content; mostly useful in cases when the extra markup is required for styling purposes.

This pull request relies on the code introduced by the #133 pull-request, so it should only be merged if the other one has already being merged.

Hello @lucasconstantino, this looks like a good improvement. I've added some inline comments.

I've seen this depends on the "responseAlter" patch and its changes are bundled here too. I'll leave comments about that to the other thread.

Once you approve the other pull-request, it is probable that the changes present in this pull-request will reduce to the actual difference - not sure though.

You might be right. But there were changes on the other pull request, that will require some adjustments here.

Anyway, we are very close to integrate both :)

Hello Lucas, please take a look at my inline comments, this is almost ready to go just needs a few tweaks, but it depends on #133.

Needs to be re-rolled and also some RouteController related code need to be removed. I believe we will need a rebase and a push to a clean branch here. Maybe a rebase and a squash.