kanagawa.nvim icon indicating copy to clipboard operation
kanagawa.nvim copied to clipboard

hlgroups/NormalFloat/FloatBorder: Consider using the color sumiink1 instead of bg_dark

Open CleoMenezesJr opened this issue 3 years ago • 2 comments

Currently, LSP diagnostics, using a floating style in my case, shows a background that does not match the original background. This occurs with other apps that use floating styles such as searchbox.nvim as shown in the issue #72.

  • LSP diagnostic

    • Before image
    • After image
  • SearchBox.nvim

    • Before image
    • After image

CleoMenezesJr avatar Sep 06 '22 22:09 CleoMenezesJr

Hlgroups should use theme color names (i.e. bg), not palette colors.

This was a tough decision, but I preferred floating windows to have a darker background. It arguably looks bad with common borders tho.

Personally I use box characters that are drawn on the outer margin of the character grid. I'll give it a try and might reconsider tho.

rebelot avatar Sep 07 '22 00:09 rebelot

This can be solved using the following configs, without changing the code:

	vim.api.nvim_set_hl(0, "NormalFloat", { bg = "#1F1F28", blend = 0})
	vim.api.nvim_set_hl(0, "FloatBorder", { bg = "#1F1F28"})
	vim.api.nvim_set_hl(0, "FloatTitle", { bg = "none"})

vicrdguez avatar Feb 13 '23 15:02 vicrdguez