sphinx_rtd_theme icon indicating copy to clipboard operation
sphinx_rtd_theme copied to clipboard

Published 20 hours ago • verified publisher icon readthedocs

Decouple menu expand and collapse from active item

Open jessetan opened this issue 7 years ago • 4 comments

This PR introduces the ability to expand and collapse menu items independent of the current active item. Before this, collapsing and expanding a menu item was coupled to the styling and logic that colored and highlighted the active item.

  • Makes hover colors and expand/collapse icon colors consistent over all menu items:

    Old New
    hover old hover new

  • Expanding a non-active menu item no longer collapses the active menu item. Collapsing the active menu item no longer makes it look inactive.

    Old New
    expand old expand new

  • Clicking the active item no longer makes it look inactive (#306)

  • Adds some comments and slight cleanup of the menu CSS.

Fixes #306 amongst others. Prerequisite for #455.

jessetan avatar Oct 26 '18 14:10 jessetan

Overall I really like this change. I haven't had much chance to go over code yet.

Blendify avatar Oct 29 '18 13:10 Blendify

Looking forward to this for #455! :)

mahmoud avatar Nov 08 '18 19:11 mahmoud

Is there any chance that this MR gets accepted anytime soon? Thanks

springer13 avatar Aug 29 '19 17:08 springer13

@jessetan any chance that you can update this to master? And revert the changes to the background/hover colors. I am not against that change but rather it be in a separate PR.

Blendify avatar Mar 12 '21 03:03 Blendify