readthedocs.org icon indicating copy to clipboard operation
readthedocs.org copied to clipboard

Can't set "Default branch" after converting repo from hg -> git

Open ahal opened this issue 3 years ago • 2 comments

Details

  • Read the Docs project URL: https://readthedocs.org/projects/taskcluster-taskgraph/

This project recently moved from Mercurial -> Git. But when I switched the repository type in the settings, the branch dropdown under advanced is still displaying the values for Mercurial (e.g default). I have no option to change my branch to main and then builds fail because rtd defaults to master.

Expected Result

Default branch drop down should update to reflect repository type changes.

Actual Result

Default branch drop down does not update to reflect repository type changes.

ahal avatar Apr 13 '22 14:04 ahal

I may try deleting and re-creating the project if there is no other workaround here (hopefully that doesn't cause namespace issues).

ahal avatar Apr 13 '22 14:04 ahal

Actually I was able to work around this by editing the value of the option in the dropdown via browser inspector :). This is still a legit issue, but I'm not blocked on it anymore.

ahal avatar Apr 13 '22 14:04 ahal

Have a possibly related issue: image

Created the project with default, from GitHub, assuming it would pick up main but tries to build master. Why is this a dropdown instead of a text box in the first place?

puttehi avatar Nov 23 '22 13:11 puttehi

@puttehi

Created the project with default, from GitHub, assuming it would pick up main but tries to build master.

As a workaround for now, you can delete and re-create the project specifying main as the default branch.

humitos avatar Nov 23 '22 13:11 humitos

@ahal we deployed https://github.com/readthedocs/readthedocs.org/pull/9424 which is a potential fix for this. Would you please try this case again and let us know if it's solved now?

humitos avatar Jan 31 '23 16:01 humitos

If the fix is supposed to auto detect that a repository changed their default branch on GitHub from "master" to "main" and then provide "main" as a dropdown option instead of "master", then no, it does not appear that the change fixed that. I still see "master" instead of "main" as a build option.

image

SethMMorton avatar Feb 01 '23 15:02 SethMMorton

@SethMMorton No, the fix is not being blocked without being able to build a version properly. The git clone command should not fail immediately saying that the master branch was not found. Only if the "Default branch" is not defined (i.e. -------) in you project's settings.

humitos avatar Feb 01 '23 15:02 humitos

This issue seems solved already. If you consider it's not, please let us know what's missing from our side and feel free to re-open it.

humitos avatar Jun 26 '23 06:06 humitos

Have a possibly related issue: image

Created the project with default, from GitHub, assuming it would pick up main but tries to build master. Why is this a dropdown instead of a text box in the first place?

I still have the exact same issue actually. Was the fix released?

carlocagnetta avatar Nov 10 '23 13:11 carlocagnetta