react.dev icon indicating copy to clipboard operation
react.dev copied to clipboard

Change in Handling events page

Open rravishankar opened this issue 3 years ago • 5 comments

https://reactjs.org/docs/handling-events.html

Handling Events -> Passing Arguments to Event Handlers

Since the event argument may not always be second, but actually is always the last, this change proposes to make it clear.

rravishankar avatar Jun 25 '22 15:06 rravishankar

Hi @rravishankar!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Jun 25 '22 15:06 facebook-github-bot

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

github-actions[bot] avatar Jun 25 '22 15:06 github-actions[bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Jun 25 '22 16:06 facebook-github-bot

Since the event argument may not always be second, but actually is always the last, this change proposes to make it clear.

It is in this example it is second though so better be explicit about it. Could you clarify when it would not be the second argument?

eps1lon avatar Jun 28 '22 09:06 eps1lon

Not sure. I view it from an implementation point of view - in the holding data structure, it would be either the first or last. I'm probably reviewing it the way I review IETF standards, feel free to ignore :)

On 28-Jun-2022 15:01, Sebastian Silbermann wrote:

Since the event argument may not always be second, but actually is always the last, this change proposes to make it clear.

It is in this example it is second though so better be explicit about it. Could you clarify when it would not be the second argument?

— Reply to this email directly, view it on GitHub https://github.com/reactjs/reactjs.org/pull/4773#issuecomment-1168474759, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADCL3YT754H6MQEHGTFPDDTVRLA6ZANCNFSM5Z2NNZ2A . You are receiving this because you were mentioned.Message ID: @.***>

rravishankar avatar Jun 28 '22 10:06 rravishankar