directory icon indicating copy to clipboard operation
directory copied to clipboard

Adding Snap Kit React Native

Open ramanpreetSinghKhinda opened this issue 4 years ago • 7 comments

📝 Why & how

Add a new library https://www.npmjs.com/package/@snapchat/snap-kit-react-native Pair: @safaiyeh

✅ Checklist

  • [X] Added library to react-native-libraries.json
  • [ ] Updated library in react-native-libraries.json
  • [ ] Documented in this PR how to use the feature or replicate the bug.
  • [ ] Documented in this PR how you fixed or created the feature.

ramanpreetSinghKhinda avatar Oct 07 '21 00:10 ramanpreetSinghKhinda

Hey @Simek we wanted to launch Snap's official RN library on directory. Github cannot be public yet could it link to the NPM package

safaiyeh avatar Oct 07 '21 00:10 safaiyeh

Hello guys, unfortunately we do not have a support for closed-source packages at this moment.

The GitHub repo and data extracted from the GitHub API about the repo and package are essential for getting metadata, scoring entry and it is a source of most of data which is displayed at the end.

Simek avatar Oct 07 '21 08:10 Simek

Thanks @Simek there is a plan to open source it at some point. Will leave it to @ramanpreetSinghKhinda to update this addition when Snap gets it open sourced

safaiyeh avatar Oct 07 '21 16:10 safaiyeh

Thanks @Simek and @safaiyeh . We can update this after open sourcing but can we still have this pushed with the npm repo only?

ramanpreetSinghKhinda avatar Oct 07 '21 17:10 ramanpreetSinghKhinda

can we still have this pushed with the npm repo only?

@ramanpreetSinghKhinda Unfortunately no, as you can see it breaks the validation and it would break the data fetch and the deploy.

There is no way around, besides refactoring a bunch of code and changing scoring methods to accommodate the lack of essential so far data.

Simek avatar Oct 07 '21 19:10 Simek

@Simek so will a private Github repo link work? If not, we can update this PR once we open source.

ramanpreetSinghKhinda avatar Oct 08 '21 20:10 ramanpreetSinghKhinda

@Simek so will a private Github repo link work? If not, we can update this PR once we open source.

It will only work if you provide ACCESS_TOKEN for the scrapper, but ATM there is no such feature on the scrapper side and generally we would like to stick only to the open source projects.

Feel free to update the PR when the library will be open sourced and re-request the review. 🙂

Simek avatar Oct 31 '21 12:10 Simek