react-native-camera

react-native-camera copied to clipboard

• The camera on android was not opening as soon as the user granted the authorization, because the refreshAuthorization was not being updated on realtime. After the user grants the authorization, it still displayed the black screen with the spinning activityIndicator. But now with the change, as soon as the user grants the permission, it opens up the camera right away.
• Refactor the code to use the refreshAuthorization in ComponentDidMount, realize the function was created but never used and in ComponentDidMount was just a copy paste of that code's function.

Steps to reproduce

Install on the device and authorize the permission then camera will open up right away in Android

Compatibility

OS	Implemented
iOS	✅❌
Android	✅❌

• [X] I have tested this on a device and a simulator
• [ ] I added the documentation in README.md
• [ ] I mentioned this change in CHANGELOG.md
• [X] I updated the typed files (TS and Flow)
• [ ] I added a sample use of the API in the example project (example/App.js)

Interesting, is this from the latest version? I haven't really noticed any delay after authorization is granted. Would this trigger a double render?

to fix the Circle CI issue, I suggest you to:

origin is njinou github repo upstream is react-native-community repo

git checkout <my-local-branch>
git fetch upstream
git rebase upstream/master
git push origin <my-local-branch>

you may have to use git push origin <my-local-branch> --force.