Midier icon indicating copy to clipboard operation
Midier copied to clipboard

Published 20 hours ago • verified publisher icon razrotenberg

Does it support MIDI channels?

Open damirka opened this issue 4 years ago • 3 comments

Hello there. Maybe I'm too new in C++ world, but by looking at source code I haven't found MIDI channelling anywhere. Can you help me do this?

damirka avatar Nov 13 '20 16:11 damirka

Hi @damirka and thanks for reaching out! So I personally didn't need to control the MIDI channel and just used channel 0 hard coded. This could be easily changed though. All there needs to be done is propagate a variable all the way to send() method in midi.cpp instead of the hard coded value (https://github.com/levosos/Midier/blob/master/src/midi/midi.cpp#L17).

Let me know if you want to open a pull request with these changes or if I can help you doing that!

razrotenberg avatar Nov 22 '20 04:11 razrotenberg

Okay @levosos, let's do it this way: I'll make my first PR on C++, and if there's something wrong you'll help me fix this. 😆

damirka avatar Nov 22 '20 13:11 damirka

No problem :-)

razrotenberg avatar Nov 22 '20 15:11 razrotenberg