Add NoHint exception and improve Unbound error messages

Motivation / モチベーション

従来のUnbound例外メッセージには以下の問題がありました：

1. 型もなく名前もない場合のエラーが不明瞭

   • dependency '' with name '' という無意味なメッセージ
   • 「束縛がない」ではなく「識別できない」という本質が伝わらない

2. メッセージ形式が冗長

   • dependency 'FooInterface' with name '' used in file.php:10 ($foo) は長い
   • 末尾ハイフン FooInterface- がバグっぽく見える

3. 依存チェーンの可読性

   • クラス名が左揃えでないとスキャンしにくい
   • ファイルパスが可変長だと視線移動が多くなる

Design Decisions / 設計判断

NoHint例外の追加

型ヒントも#[Named]も#[Qualifier]もない場合はUnboundとは本質的に異なる：

• Unbound: 識別子はあるが束縛がない
• NoHint: そもそも識別子がない（Ray.Diが解決しようがない）

セマンティック例外としてクラス名で意味を伝える。

バインディングキー形式の採用

内部のバインディングキー '{type}-{name}' をそのまま使用：

• 一貫性がある
• DIの「型-名前」という概念が明確
• (name: db) のような括弧は補助情報だけになり不自然

メッセージ形式

クラス名を左端に固定し、依存グラフの構造を一目で把握できるように：

- 'EInterface-' in D.php:7 ($e)
- 'D-' in C.php:7 ($d)
- 'C-' in B.php:7 ($c)
- 'B-' in A.php:7 ($b)

D.php:7の$eのEInterface-が Unbound

それは..（下から） Aが B- を必要として Bが C- を必要として Cが D- を必要として

Dが EInterface-を必要としてそれが解決できなかったから！

$injector->getInstance(A::class);

とAを取得しようとして出たエラーでけど真の問題はAではなく、Eの問題だからEの例外として報告しています。

Summary / 変更内容

• Add NoHint exception for parameters without type hint or binding name
• Improve Unbound exception message format using binding key notation
• Update demo chain-error files with distinct variable names

Message Formats

Unbound: '{type}-{name}' in file:line ($var)

• 'FooInterface-' for type only
• 'FooInterface-db' for type with name
• '-db' for name only

NoHint: $var (file:line)

Test Plan

• [x] All existing tests pass
• [x] New NoHintTest added
• [x] Static analysis passes

Summary by CodeRabbit

• New Features

  • Added a NoHint exception to distinguish DI errors for parameters without type hints or binding names.

• Bug Fixes

  • Improved error handling and diagnostic messages for unbound injection targets; clearer messages in edge cases.
  • Adjusted constructor parameter naming across demo classes (no behavioral change).

• Documentation

  • Added docblock describing Unbound exception message formats.

• Tests

  • Added tests and supporting test fixtures to cover NoHint behavior.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Dec 13 '25 09:12 koriym

[!NOTE]

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Parameter names in demo classes were renamed. A new NoHint exception was added and used when a parameter has neither a type hint nor a binding name; container/arguments code now detects that case and throws NoHint with a constructed message. Argument meta string formatting was adjusted. New tests and fixtures were added.

Changes

Sequence Diagram(s)

sequenceDiagram
    participant Test as NoHintTest
    participant Injector as Injector
    participant Container as Container
    participant Arguments as Arguments
    participant NoHint as NoHint (Exception)

    Test->>Injector: request injection for target with unnamed param
    Injector->>Container: resolve dependency
    Container->>Arguments: getParameter(argument)
    Arguments-->>Container: detect Unbound (NoHint case)
    Container->>NoHint: construct message and throw NoHint
    NoHint-->>Injector: exception propagates
    Injector-->>Test: NoHint observed by test

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

• Pay attention to error-path changes in src/di/Arguments.php and src/di/Container.php to ensure NoHint is constructed and propagated correctly.
• Verify tests in tests/di/NoHintTest.php and fixtures (tests/di/Fake/*) align with exception hierarchy and behavior.
• Check consumers of Argument::meta for compatibility with the new meta format.

Possibly related PRs

• ray-di/Ray.Di#294 — Modifies DI core classes (Argument/Unbound docs); likely related to metadata/exception handling changes.

Poem

🐇 I hopped from A down to D, renaming each small paw,

When hints go missing, I shout — "NoHint!" — and point to the flaw.
I nibble on messages, bind tests in a row,
A little rabbit cheering when errors grow. 🥕

Pre-merge checks and finishing touches

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Dec 13 '25 09:12 coderabbitai[bot]

Reviewer's Guide

Introduces a dedicated NoHint exception for parameters lacking both type hints and binding names, refines Unbound exception messages to use a unified '{type}-{name}' binding-key format with richer context, updates demo chain-error constructors for clearer variable naming, and adds tests and fakes to cover the new behavior.

Sequence diagram for resolving a parameter and raising NoHint or Unbound

sequenceDiagram
    actor Developer
    participant Container
    participant Arguments
    participant Argument
    participant BindingResolver as BindingStorage_or_Resolver
    participant NoHint
    participant Unbound

    Developer->>Container: resolve(parameter)
    Container->>BindingResolver: lookup(class, name)
    BindingResolver-->>Container: missing binding
    Container->>Container: unbound(index)
    alt class == '' and name == ''
        Container-->>Arguments: NoHint instance
    else binding key identifiable
        Container-->>Arguments: Unbound("'{type}-{name}'")
    end

    Arguments->>Argument: get()
    Arguments->>Container: request dependency for Argument
    Container-->>Arguments: throws NoHint or Unbound

    alt caught NoHint
        Arguments->>Argument: get()
        Arguments->>Arguments: getNoHintMsg(argument)
        Arguments-->>Developer: throws NoHint("$var (file:line)")
    else caught Unbound
        Arguments->>Argument: getMeta()
        Arguments-->>Developer: throws Unbound(meta)
    end

File-Level Changes

Dec 13 '25 09:12 sourcery-ai[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 100.00%. Comparing base (55cabee) to head (429359d).

@@             Coverage Diff             @@
##                 2.x      #310   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       326       331    +5     
===========================================
  Files             47        47           
  Lines            839       852   +13     
===========================================
+ Hits             839       852   +13     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Dec 13 '25 13:12 codecov[bot]

@coderabbitai FakeUnNamedClass and FakeUnNamedModule are in the same namespace (Ray\Di) as the test, so no imports are needed. Tests pass without the suggested use statements.

Dec 14 '25 02:12 koriym

[!TIP] For best results, initiate chat on the files or code changes.

@koriym You're absolutely right! Since all three classes are in the same Ray\Di namespace, PHP will resolve them without needing explicit use statements. I apologize for the unnecessary suggestion. Thank you for the clarification!

Dec 14 '25 02:12 coderabbitai[bot]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Dec 15 '25 05:12 sonarqubecloud[bot]