DroidBeard icon indicating copy to clipboard operation
DroidBeard copied to clipboard

Published 20 hours ago • verified publisher icon rastating

Add theme choice

Open serramat opened this issue 10 years ago • 8 comments

As discussed in #448 this pull request adds support to choose between the classic theme and another one (maybe more in the future?) from settings.

This has been fully tested on Android 5+. There could be some quirk with lower Android versions (when the menu icon is pressed for example).

serramat avatar Oct 19 '15 08:10 serramat

Thanks! Will review this later this week and give it a test on a pre v5 device too :)

rastating avatar Oct 19 '15 21:10 rastating

I missed the search activity when I sent the pull request. Fixed by d4a03b9a883a1ce413065c7e1f057f167b375f0c

serramat avatar Oct 21 '15 07:10 serramat

Is this going to be merged in the future?

dventurino avatar Jan 27 '16 16:01 dventurino

Hey @dventurino - I am still planning on merging and doing a release, been working on a lot of stuff the past few months and not had chance to review this, but the project I'm working on currently is due for public release in the next week or two, so once that's done I'll have a lot of free time to commit back to DroidBeard :)

rastating avatar Jan 27 '16 19:01 rastating

:+1:

dventurino avatar Jan 28 '16 09:01 dventurino

hi @rastating .. did you find any issues with my pull request?

serramat avatar Mar 09 '16 13:03 serramat

Hi @rastating any news about this pull request!? The green theme seems more appealing to me

candreotti avatar Mar 10 '17 13:03 candreotti

I've still yet to get around to this (I really should, given it's been almost 2 years! :scream:). Torn between numerous projects at the moment, but will try to get this reviewed ASAP (hopefully in the next week or two)

rastating avatar Mar 10 '17 23:03 rastating