cugraph icon indicating copy to clipboard operation
cugraph copied to clipboard

PropertyGraph set index to vertex and edge ids

Open eriknw opened this issue 3 years ago • 8 comments

~Currently, this only does SG version for #2401. MG is still TODO.~

Closes #2401

This also doesn't change anything user-facing (yet).

eriknw avatar Aug 09 '22 23:08 eriknw

Codecov Report

:exclamation: No coverage uploaded for pull request base (branch-22.10@238f909). Click here to learn what that means. Patch has no changes to coverable lines.

:exclamation: Current head 6a365ec differs from pull request most recent head 6a7ff4e. Consider uploading reports for the commit 6a7ff4e to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-22.10    #2523   +/-   ##
===============================================
  Coverage                ?   60.13%           
===============================================
  Files                   ?      111           
  Lines                   ?     6184           
  Branches                ?        0           
===============================================
  Hits                    ?     3719           
  Misses                  ?     2465           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Aug 10 '22 01:08 codecov-commenter

@eriknw is this ready for review?

alexbarghi-nv avatar Aug 18 '22 18:08 alexbarghi-nv

Yeah, for SG. I'm going to put MG into a different WIP branch, because of issues I'm having with dask_cudf.

I still want to add one thing: the ability to add vertex data that already has the vertex id as the index.

eriknw avatar Aug 18 '22 18:08 eriknw

ok, I'll wait until you've made that addition, I wasn't sure if that was going into this branch or not

alexbarghi-nv avatar Aug 18 '22 18:08 alexbarghi-nv

rerun tests

BradReesWork avatar Sep 14 '22 15:09 BradReesWork

rerun tests

BradReesWork avatar Sep 19 '22 13:09 BradReesWork

rerun tests

alexbarghi-nv avatar Sep 21 '22 02:09 alexbarghi-nv

rerun tests

BradReesWork avatar Sep 23 '22 17:09 BradReesWork

rerun tests

BradReesWork avatar Sep 30 '22 14:09 BradReesWork

@gpucibot merge

BradReesWork avatar Sep 30 '22 19:09 BradReesWork