Rafael Schouten

Results 910 comments of Rafael Schouten

I like the idea, but I'm not sure about overloading the term "keys" as that already means something else for an array.

Sorry forgot to answer, but no. I've struggled with this too.

Since you are defining `relayout_constructor` do you know about `ConstructionBase.constructorof` ? It may be useful here. https://github.com/JuliaObjects/ConstructionBase.jl It's already possible to remove Adapt.jl using `constructorof`, such as with Flatten.jl: `Flatten.modify(CuArray,...

Ok good to know you've been thinking about that already. I can see how wanting more specific behaviors for some types is useful, like returning an entirely different wrapper -...

Sure! My comment was much more general, for the long term of widely-used methods for reconstructing things. I wish I understood more of the details of your PRs to comment...

Sorry I never got around to this, too many other packages. Personally I have switched to using DimensionalData.jl for this. You can pass a tuple wrapped in Val into a...

Ok, I'll need to improve the docs a little for this at DimensionalData.jl as this functionality is only a few weeks old, then I'll clean up here.

This is partially true, but in practice it will be very difficult for axis indexing to work correctly through multiple outer wrappers. Axis lookup wrappers like `DimArray` usually leave the...

Yes there would need to be fairly specific scope. Outside of Base, things like `CuArray` and `DistributedArray` (or is is `DArray`?) are a good example of an array type that...

Ok I'm keen to see what you come up with! Although I'm still concerned that a lot of edge cases will mean we still need dispatch on `AbstractDimArray` for DimensionalData.jl...