RecyclerView-FastScroller

RecyclerView-FastScroller copied to clipboard

Support programmatic enabling/disabling of fastscroller

[{"_id":"63836ba65ae95c7a223343f7","body":"would you like to pick this up @marcardar ? ","issue_id":1660305681047,"origin_id":695173344,"user_origin_id":12149313,"create_time":1600497451,"update_time":1600497451,"id":1669557158127,"updated_at":"2022-11-27T13:52:38.126000Z","created_at":"2022-11-27T13:52:38.126000Z"},{"_id":"63836ba65ae95c7a223343f8","body":"@shahsurajk unfortunately I'm really snowed under at the moment :(","issue_id":1660305681047,"origin_id":695174507,"user_origin_id":409640,"create_time":1600498303,"update_time":1600498303,"id":1669557158132,"updated_at":"2022-11-27T13:52:38.132000Z","created_at":"2022-11-27T13:52:38.132000Z"},{"_id":"63836ba65ae95c7a223343f9","body":"When is this enhancement going to be released??\r\n","issue_id":1660305681047,"origin_id":1194092975,"user_origin_id":79929840,"create_time":1658757884,"update_time":1658757884,"id":1669557158136,"updated_at":"2022-11-27T13:52:38.135000Z","created_at":"2022-11-27T13:52:38.135000Z"}]

At the moment, this can only be done through the XML (fastScrollEnabled), but often we want to enable/disable according to, for example, how many items there are in the list....

marcardar

Crash adapterDataObserver was not registered

[]

java.lang.IllegalStateException: Observer com.qtalk.recyclerviewfastscroller.RecyclerViewFastScroller$adapterDataObserver$1$1@4a87042 was not registered. at android.database.Observable.unregisterObserver(Observable.java:69) at androidx.recyclerview.widget.RecyclerView$Adapter.unregisterAdapterDataObserver(RecyclerView.java:7537) at com.qtalk.recyclerviewfastscroller.RecyclerViewFastScroller.detachFastScrollerFromRecyclerView(Unknown Source:31) at com.qtalk.recyclerviewfastscroller.RecyclerViewFastScroller.onDetachedFromWindow(Unknown Source:0) at android.view.View.dispatchDetachedFromWindow(View.java:20534) at android.view.ViewGroup.dispatchDetachedFromWindow(ViewGroup.java:3942) at android.view.ViewGroup.dispatchDetachedFromWindow(ViewGroup.java:3934) at android.view.ViewGroup.dispatchDetachedFromWindow(ViewGroup.java:3934) at android.view.ViewGroup.dispatchDetachedFromWindow(ViewGroup.java:3934) at android.view.ViewGroup.removeViewInternal(ViewGroup.java:5560) at android.view.ViewGroup.removeViewAt(ViewGroup.java:5507)...

omkar-tenkale

Crash - lateinit property recyclerView has not been initialized

[{"_id":"6383719c70db72139b148cdc","body":"Happens after recycler is initialized with adapter and then the fastscroll.attach is called","issue_id":1660305681053,"origin_id":1094142434,"user_origin_id":39808155,"create_time":1649547987,"update_time":1649547987,"id":1669558684825,"updated_at":"2022-11-27T14:18:04.825000Z","created_at":"2022-11-27T14:18:04.825000Z"}]

kotlin.UninitializedPropertyAccessException: lateinit property recyclerView has not been initialized at com.qtalk.recyclerviewfastscroller.RecyclerViewFastScroller.access$getRecyclerView$p(Unknown Source:6) at com.qtalk.recyclerviewfastscroller.RecyclerViewFastScroller$alignTrackAndHandle$5.run(Unknown Source:111) at android.os.Handler.handleCallback(Handler.java:938) at android.os.Handler.dispatchMessage(Handler.java:99) at android.os.Looper.loop(Looper.java:223) at android.app.ActivityThread.main(ActivityThread.java:7656) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)

omkar-tenkale

Issues with "Changes sample app to use view pager 2"

[{"_id":"638368d45ae95c7a22333f6f","body":"I have the same problem, and found out that rewriting the function `registerDataObserver()` of the library as follows did seem to circumvent the crash. But I'm not sure this tackles the root of the issue. \r\n\r\nThe problem seems to be caused because the observer is registered more than once before being detached. It is first registered in `initImpl()` and then, every time you click and scroll down using the scrollbar, the observer is registered again at line 418.\r\n\r\n@shahsurajk would you happen to have any insight on the issue?\r\n\r\nBy the way, this is the same issue as #43 \r\n\r\nMy temporary fix:\r\n```\r\nprivate fun registerDataObserver() {\r\n if (recyclerView.adapter?.hasObservers() != true) {\r\n recyclerView.adapter?.registerAdapterDataObserver(adapterDataObserver.value)\r\n }\r\n}\r\n```","issue_id":1660305681058,"origin_id":1088669869,"user_origin_id":32095402,"create_time":1649163353,"update_time":1649163455,"id":1669556436778,"updated_at":"2022-11-27T13:40:36.778000Z","created_at":"2022-11-27T13:40:36.778000Z"},{"_id":"638368d45ae95c7a22333f70","body":"I have exactly the same problem and I hope it'll be fixed because it's one of the most popular libraries that I think most developers use!","issue_id":1660305681058,"origin_id":1091260112,"user_origin_id":21770946,"create_time":1649318941,"update_time":1649318941,"id":1669556436785,"updated_at":"2022-11-27T13:40:36.784000Z","created_at":"2022-11-27T13:40:36.784000Z"},{"_id":"66320ef6fa3686d6a10ee15a","body":"I solved it. Check my answer here - [solution](https:\/\/github.com\/quiph\/RecyclerView-FastScroller\/issues\/43#issuecomment-1409879055)","issue_id":1660305681058,"origin_id":1409880794,"user_origin_id":33550494,"create_time":1675149392,"update_time":1675149392,"id":1714556662321,"updated_at":"2024-05-01T09:44:22.321000Z","created_at":"2024-05-01T09:44:22.321000Z"}]

I've experienced various issues in the sample app, after the above commit, which is on the development branch as of 26 Nov 2020. I put them all here in the...

kaaholst

Add option to disable touch on the invisible track

[{"_id":"6383673a70db72139b148193","body":"@tom5079 Let's add reference this issue in #32 by amending the last commit message\r\n","issue_id":1660305681061,"origin_id":695176463,"user_origin_id":12149313,"create_time":1600499546,"update_time":1600499546,"id":1669556026263,"updated_at":"2022-11-27T13:33:46.263000Z","created_at":"2022-11-27T13:33:46.263000Z"},{"_id":"6383673a70db72139b148194","body":"just comment out trackView.setOnTouchListener(touchListener) at https:\/\/github.com\/quiph\/RecyclerView-FastScroller\/blob\/0ba9c9a4ac37c0041e7941865a9a822c42f631a9\/recyclerviewfastscroller\/src\/main\/java\/com\/qtalk\/recyclerviewfastscroller\/RecyclerViewFastScroller.kt#L498 for it. Do not be confused by it not working in the sample app, the recyclerView actually has side margins and it doesn't go below the track. Pretty bad UX I'd say :)","issue_id":1660305681061,"origin_id":968350919,"user_origin_id":528931,"create_time":1636918665,"update_time":1636918685,"id":1669556026269,"updated_at":"2022-11-27T13:33:46.268000Z","created_at":"2022-11-27T13:33:46.268000Z"}]

It would be nice to have some kind of option to disable touch on the invisible track Sometimes users touch it accidentally without knowing that it would actually move to...

tom5079

Scroll handle is not positionned properly when scrolling the recycling view

[{"_id":"63836bad4b97542c9a33e418","body":"Hmm, this surely looks like a bug and is not related to the TODO mentioned. Thanks for letting us know! ","issue_id":1660305681064,"origin_id":753653648,"user_origin_id":12149313,"create_time":1609696687,"update_time":1609696687,"id":1669557165743,"updated_at":"2022-11-27T13:52:45.743000Z","created_at":"2022-11-27T13:52:45.743000Z"},{"_id":"63836bad4b97542c9a33e419","body":"Is this issue the same as I show here, after modifying the sample a bit:\r\n\r\n[KK5iETTupT.zip](https:\/\/github.com\/quiph\/RecyclerView-FastScroller\/files\/5823462\/KK5iETTupT.zip)\r\n\r\n[RecyclerView-FastScroller.zip](https:\/\/github.com\/quiph\/RecyclerView-FastScroller\/files\/5823463\/RecyclerView-FastScroller.zip)\r\n\r\n?\r\n\r\nBasicAdapter - changed number of items to 10.\r\nrecycler_view_list_item_center.xml - changed item height to 100dp\r\n\r\nMaybe this library could help fix this:\r\nhttps:\/\/github.com\/zhanghai\/AndroidFastScroll\r\n?","issue_id":1660305681064,"origin_id":761268098,"user_origin_id":5357526,"create_time":1610755817,"update_time":1610758262,"id":1669557165746,"updated_at":"2022-11-27T13:52:45.746000Z","created_at":"2022-11-27T13:52:45.746000Z"},{"_id":"63836bad4b97542c9a33e41a","body":"@AndroidDeveloperLB Yes your video is the issue that I have","issue_id":1660305681064,"origin_id":761545080,"user_origin_id":1484692,"create_time":1610795166,"update_time":1610795166,"id":1669557165751,"updated_at":"2022-11-27T13:52:45.751000Z","created_at":"2022-11-27T13:52:45.751000Z"},{"_id":"63836bad4b97542c9a33e41b","body":"@bperel Thank you. Do you know of any workaround of this?","issue_id":1660305681064,"origin_id":761546310,"user_origin_id":5357526,"create_time":1610795670,"update_time":1610795670,"id":1669557165754,"updated_at":"2022-11-27T13:52:45.753000Z","created_at":"2022-11-27T13:52:45.753000Z"},{"_id":"63836bad4b97542c9a33e41c","body":"No, I didn't find a workaround: my project can't use the library until this bug is fixed since it prevents the user from scrolling through the content properly","issue_id":1660305681064,"origin_id":761584034,"user_origin_id":1484692,"create_time":1610811749,"update_time":1610811749,"id":1669557165756,"updated_at":"2022-11-27T13:52:45.756000Z","created_at":"2022-11-27T13:52:45.756000Z"},{"_id":"63836bad4b97542c9a33e41d","body":"@bperel OK thank you. ","issue_id":1660305681064,"origin_id":761706727,"user_origin_id":5357526,"create_time":1610844420,"update_time":1610844420,"id":1669557165758,"updated_at":"2022-11-27T13:52:45.758000Z","created_at":"2022-11-27T13:52:45.758000Z"},{"_id":"63836bad4b97542c9a33e41e","body":"Since this project hasn't been updated in a year and I haven't extensively tested this solution, I'm leaving this here as a comment instead of submitting a PR in case anyone else has come across this issue.\r\n\r\nThere seems to be an issue with the math `onScrolled`\r\n\r\nEnded up replacing https:\/\/github.com\/quiph\/RecyclerView-FastScroller\/blob\/v1.0.0\/recyclerviewfastscroller\/src\/main\/java\/com\/qtalk\/recyclerviewfastscroller\/RecyclerViewFastScroller.kt#L906-L909 with\r\n\r\n```\r\nval availableTrackLength = extent.toFloat() - handleLength\r\nval scrollPositionPercent = (offset.toFloat() \/ (range - extent))\r\nval finalOffset = availableTrackLength * scrollPositionPercent\r\n\r\nmoveHandle(finalOffset)\r\n```","issue_id":1660305681064,"origin_id":946068400,"user_origin_id":7101723,"create_time":1634583344,"update_time":1634583442,"id":1669557165770,"updated_at":"2022-11-27T13:52:45.770000Z","created_at":"2022-11-27T13:52:45.770000Z"},{"_id":"66320efbfa3686d6a10ee15e","body":"I have the same issue.","issue_id":1660305681064,"origin_id":1828594173,"user_origin_id":58298629,"create_time":1701118666,"update_time":1701118666,"id":1714556667832,"updated_at":"2024-05-01T09:44:27.832000Z","created_at":"2024-05-01T09:44:27.832000Z"}]

Hello and thank you for this project. I have noticed an issue when the list contains a small number of elements. It can be reproduced by only keeping the first...

bperel

Add option to disable track

[{"_id":"638372af70db72139b148e02","body":"@shahsurajk anyone?","issue_id":1660305681065,"origin_id":774158493,"user_origin_id":7948651,"create_time":1612544484,"update_time":1612544484,"id":1669558959281,"updated_at":"2022-11-27T14:22:39.281000Z","created_at":"2022-11-27T14:22:39.281000Z"},{"_id":"638372af70db72139b148e03","body":"Is this project dead? :skull:","issue_id":1660305681065,"origin_id":879481930,"user_origin_id":7948651,"create_time":1626221000,"update_time":1626221000,"id":1669558959284,"updated_at":"2022-11-27T14:22:39.284000Z","created_at":"2022-11-27T14:22:39.284000Z"},{"_id":"638372af70db72139b148e04","body":"@tom5079 it's not dead. it's just looking for contributors. And i was unable to look into the PR. Will do so soon. Sorry for the inconvenience.\r\n\r\n","issue_id":1660305681065,"origin_id":879646164,"user_origin_id":12149313,"create_time":1626246157,"update_time":1626246157,"id":1669558959288,"updated_at":"2022-11-27T14:22:39.287000Z","created_at":"2022-11-27T14:22:39.287000Z"}]

Fixes #26

tom5079

For #16 add a grid layout option to the basic tab

[]

This PR demonstrates that the fast scroller does work with a GridLayoutManager. Instead of adding a fragment with a grid layout, I've added a button to toggle list and grid...

kaaholst

China's population has multiple numbers

[{"_id":"6383716f5ae95c7a22334aee","body":"@cmilousi always happy to have contributions to the project. \r\n\r\non the multiple numbers issue, i think, it would be a good idea to highlight the selected item in the sample. from the screen record, what i can make out is that as you move the fast scroller the adapter moves the selected item too. ","issue_id":1660305681070,"origin_id":759484302,"user_origin_id":12149313,"create_time":1610548110,"update_time":1610548110,"id":1669558639790,"updated_at":"2022-11-27T14:17:19.789000Z","created_at":"2022-11-27T14:17:19.789000Z"},{"_id":"6383716f5ae95c7a22334aef","body":"i think we should first update the example and highlight the selected element, use the callbacks provided [here](https:\/\/github.com\/quiph\/RecyclerView-FastScroller#linking-with-items)","issue_id":1660305681070,"origin_id":759489453,"user_origin_id":12149313,"create_time":1610548597,"update_time":1610548597,"id":1669558639793,"updated_at":"2022-11-27T14:17:19.792000Z","created_at":"2022-11-27T14:17:19.792000Z"},{"_id":"6383716f5ae95c7a22334af0","body":"@shahsurajk to be more specific at 0:14 you can see that as I scroll but still remain in China the population goes from \r\n1.3B -> 1.0B -> 278.4M -> 237.6M -> 170.1M -> 156.5M -> 146.9M -> 129.2M -> 126.7M and at 111.5M it switches to India. \r\n\r\nAlso , sorry I didnt quite catch where should I use these callbacks?\r\n","issue_id":1660305681070,"origin_id":760033416,"user_origin_id":56234590,"create_time":1610614311,"update_time":1610614311,"id":1669558639796,"updated_at":"2022-11-27T14:17:19.795000Z","created_at":"2022-11-27T14:17:19.795000Z"}]

When I scroll to China and while I am inside China's box, it shows a lot of different numbers of population when there should only be one number referring to...

cmilousi

Population is not shown properly

[]

So in "Advanced" where the countries are listed by population as you can see from my screen recording from the moment that it reaches the "Marshall Islands" the coloured box...

cmilousi