qBittorrent icon indicating copy to clipboard operation
qBittorrent copied to clipboard

Completed icon is barely visible on Dark theme in 4.5.0beta1

Open adem4ik opened this issue 3 years ago • 6 comments

qBittorrent & operating system versions

qBittorrent: 4.5.0beta1 (build from here) Operating system: Windows 10 Pro 21H2 x64 Qt: 6.3.0 libtorrent-rasterbar: 1.2.17.0

What is the problem?

New Completed icon is barely visible in 4.5.0beta1 if the Dark theme is used.

Steps to reproduce

  1. Apply custom dark UI theme (i.e. mumble-dark-nowshed.zip)

Additional context

image

Log(s) & preferences file(s)

N/A

adem4ik avatar Sep 21 '22 11:09 adem4ik

Custom themes should provide custom icons in such cases.

glassez avatar Sep 21 '22 11:09 glassez

Well, qB already supports dark mode on Linux and (afaik) on macOS. So that icon will be barely visible anyway, even if user doesn't apply custom theme.

Here is the screenshot from Manjaro Linux w/o any custom theme, just with build-in Qt6 dark theme: image

adem4ik avatar Sep 21 '22 11:09 adem4ik

@adem4ik Are you using a TN type monitor?

@thalieht had an issue with this icon colour in initial implementation of icon changes....doesn't seem to be a problem on IPS panel.......color should be changed anyway to avoid such an issue going forward.

xavier2k6 avatar Sep 21 '22 12:09 xavier2k6

@xavier2k6 yes, I have TN type monitor.

adem4ik avatar Sep 21 '22 13:09 adem4ik

yes, I have TN type monitor.

Will change color used for completed icon & associated text in transfer list

xavier2k6 avatar Sep 21 '22 14:09 xavier2k6

Labelled with Confirmed bug as issue seems to arise with the use of TN panel type monitors & thalieht encountered it too on a TN panel monitor.

xavier2k6 avatar Sep 21 '22 14:09 xavier2k6

I doubt a TN panel is the issue, especially if they have accurate colour reproduction. What I see in this thread are two images with different shades of grey background.

The first image with custom dark contrasts better against the purple icon and I see it better.

The image here that is using the OS to theme has a lighter shade of grey with worse contrast and I can barely see it.

It's fine in this theme

https://raw.githubusercontent.com/brettpetch/nightwalker/main/preview.png

image

Just make it green ( it is a tick after all ) or clear contrast to light/dark theme. I very much doubt this is anything specific to TN panels as I don't have one and take issue with the contrast on VA/IPS

userdocs avatar Sep 22 '22 10:09 userdocs

@userdocs That's a different icon/color being used in your screenshot......anyway - will change it this wknd when I have time.

xavier2k6 avatar Sep 22 '22 12:09 xavier2k6

It's the same in the webui for 4.5 beta, the colour does not contrast well against certain shades.

2022-09-22_21-04-17

Maybe the Dracula theme might be a good reference for dark themes and suitably well contrasted colours

https://draculatheme.com/qbittorrent

userdocs avatar Sep 22 '22 20:09 userdocs

It's the same in the webui for 4.5 beta, the colour does not contrast well against certain shades. The blue checkmark that OP is seeing should be a lighter shade of blue to contrast well against the dark background.

I agree. We should have different colors for both light and dark by using a contrast checking tool. The blue checkmark that OP is seeing should be a lighter shade of blue to contrast well against the dark background. There's already a lighter blue being used for "seeding" so we can instead use a different kind of light blue like Teal or a greenlsh blue like Cyan.

blues

@now-im was working on the new themes for 4.5.0 so maybe he should have some input.

Pentaphon avatar Sep 23 '22 16:09 Pentaphon

@now-im was working on the new themes for 4.5.0 so maybe he should have some input.

I proposed to make two seperate icon pack for light and dark themes. I would have worked on it. However, I have neither the time nor the skillset to make a complete theme set.

Mazino-Urek avatar Sep 24 '22 13:09 Mazino-Urek

I proposed to make two seperate icon pack for light and dark themes. I would have worked on it. However, I have neither the time nor the skillset to make a complete theme set.

That's ok. Somebody just has to tweak the downloads checkmark to a different kind of color that stands out more on the dark theme and it will work for both themes. The current download checkmark seems like kind of a purplish blue that blends into the dark background. We just have to test different kinds of blues until one of them is clearly visible on the current dark theme background. Or we can just have somebody switch out all the colors until they are clearly visible on both dark and light backgrounds and do not conflict with each other.

Pentaphon avatar Sep 24 '22 16:09 Pentaphon

will change it this wknd when I have time.

For those who may have missed this......(setting time aside for this & other things tomorrow)

xavier2k6 avatar Sep 24 '22 16:09 xavier2k6

As I had some time to kill, I made a PR on this. Hope it is ok.

Mazino-Urek avatar Oct 26 '22 13:10 Mazino-Urek