python-geotiepoints icon indicating copy to clipboard operation
python-geotiepoints copied to clipboard

5-dimensional interpolation

Open EdGrrr opened this issue 6 years ago • 3 comments

Is there any reason that the upper limit is 4D? If I am reading the code correctly, there appears to be cython code for 5D interpolation in geotiepoints/multilinear_cython.pyx, but this has not been compiled into geotiepoints/multilinear_cython.c.

Thanks!

EdGrrr avatar Jan 02 '20 10:01 EdGrrr

It's been a while since I've looked at this code, but I think you're mostly right. If you look at this part of the cython code we can see that it is checking for 4 dimensions and then fails if it is 5 or more. The error message though seems to suggest it can handle 5 though and as you pointed out there is a function in the cython code for 5D.

I didn't write this code but maybe @mraspaud has a memory of what is going on here. My guess is someone started the 5D function and then found they didn't need it so didn't enable it. If you change the if statement in the cython code and rebuild the cython extension, you might be able to test this yourself if this is something you're comfortable with. Otherwise we'll have to wait for @mraspaud to respond.

djhoese avatar Jan 02 '20 14:01 djhoese