By default, these calls were allocating tensors on the CPU, to then convert to the device used in the rest of the model. It's faster to allocate them directly on the correct device.

I have measured these changes on my machine to reduce the runtime of the forward pass by 25%.

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8500

• :page_facing_up: Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

:x: 3 New Failures, 12 Unrelated Failures

As of commit 0714fdb8c91e07e02e1c7caec976ec5a4d38d9f2 with merge base 3e60dbd590d1aef53e443d0d2dcb792a91afe481 ():

NEW FAILURES - The following jobs have failed:

• Lint / python-types / linux-job (gh) RuntimeError: Command docker exec -t f2fc3c69822d3ffd0659d62085732079fec4eb68ca3785a82e175c930c98f5c3 /exec failed with exit code 1
• Tests / unittests-linux (3.8, linux.g5.4xlarge.nvidia.gpu, cuda, 11.8) / linux-job (gh) RuntimeError: Command docker exec -t 2c07e9591089637ff95a7f8c67c0455a16201d0c8a8391c3634b18b69a2e7efa /exec failed with exit code 1
• Tests / unittests-windows (3.8, windows.g5.4xlarge.nvidia.gpu, cuda, 11.8) / windows-job (gh) Process completed with exit code 1.

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

• Build Windows Conda / pytorch/vision / upload / conda-py3_8-cpu (gh) (trunk failure) Unable to find any artifacts for the associated workflow
• Build Windows Conda / pytorch/vision / upload / conda-py3_8-cuda11_8 (gh) (trunk failure) Unable to find any artifacts for the associated workflow
• Build Windows Conda / pytorch/vision / upload / conda-py3_8-cuda12_1 (gh) (trunk failure) Unable to find any artifacts for the associated workflow
• Build Windows Conda / pytorch/vision / upload / conda-py3_8-cuda12_4 (gh) (trunk failure) Unable to find any artifacts for the associated workflow
• Tests / unittests-linux (3.10, linux.12xlarge, cpu) / linux-job (gh) (trunk failure) test/test_io.py::TestVideo::test_write_video_with_audio[cuda]
• Tests / unittests-linux (3.12, linux.12xlarge, cpu) / linux-job (gh) (trunk failure) test/test_io.py::TestVideo::test_write_video_with_audio[cuda]
• Tests / unittests-linux (3.8, linux.12xlarge, cpu) / linux-job (gh) (trunk failure) test/test_io.py::TestVideo::test_write_video_with_audio[cuda]
• Tests / unittests-linux (3.9, linux.12xlarge, cpu) / linux-job (gh) (trunk failure) test/test_io.py::TestVideo::test_write_video_with_audio[cuda]
• Tests / unittests-macos (3.10, macos-m1-stable) / macos-job (gh) (trunk failure) test/test_io.py::TestVideo::test_write_video_with_audio[cuda]
• Tests / unittests-macos (3.12, macos-m1-stable) / macos-job (gh) (trunk failure) test/test_io.py::TestVideo::test_write_video_with_audio[cuda]
• Tests / unittests-macos (3.8, macos-m1-stable) / macos-job (gh) (trunk failure) test/test_io.py::TestVideo::test_write_video_with_audio[cuda]
• Tests / unittests-macos (3.9, macos-m1-stable) / macos-job (gh) (trunk failure) test/test_io.py::TestVideo::test_write_video_with_audio[cuda]

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Hi @vbarrielle!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Thanks for the PR @vbarrielle . PR looks good. Please make sure to sign the CLA for us to be able to merge your contribution! Thank you