serve icon indicating copy to clipboard operation
serve copied to clipboard

Gracefully handle decoding exceptions in python backend

Open msaroufim opened this issue 3 years ago • 2 comments

Fixes https://github.com/pytorch/serve/issues/1776

Test: https://colab.research.google.com/drive/1eKMiheF50YYGtPmi0WqVkeRqLk8Gbwg5?usp=sharing (would probably be better to start writing unit tests for the python backend when we have time)

The meaningful code is at the very end of the file in the try, except block

msaroufim avatar Aug 10 '22 22:08 msaroufim

Codecov Report

Merging #1789 (1a41193) into master (7a9dd02) will decrease coverage by 0.10%. The diff coverage is 57.44%.

@@            Coverage Diff             @@
##           master    #1789      +/-   ##
==========================================
- Coverage   45.38%   45.28%   -0.11%     
==========================================
  Files          64       64              
  Lines        2591     2597       +6     
  Branches       60       60              
==========================================
  Hits         1176     1176              
- Misses       1415     1421       +6     
Impacted Files Coverage Δ
ts/protocol/otf_message_handler.py 74.73% <57.44%> (-2.44%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 11 '22 02:08 codecov[bot]

@rohithkrn @lxning GPU CI seems to be frozen now

msaroufim avatar Aug 11 '22 05:08 msaroufim