serve icon indicating copy to clipboard operation
serve copied to clipboard

Deprecate neuron Dockerfile in favor in DLC

Open rohithkrn opened this issue 3 years ago • 3 comments

This change is to deprecate neuron dockerfile as it is currently broken. Instead, it's ideal at this to point use containers provided by aws/deep-learning-containers that are more reliable.

I also learnt that this was created to run performance tests but it was never run/tested.

Packages that are missing in this Dockerfile

  • python3.8, python3.8-dev, python3.8-venv, python3.8-distutils. It installs python3-dev
  • gnupg

I tried installing these packages and ran the container but it did not detect neuron devices inside the container probably because of missing drivers.

Ran the docker container like below following https://awsdocs-neuron.readthedocs-hosted.com/en/latest/neuron-deploy/dlc-then-ec2-devflow.html# docker run -it --name ts-jdk17 --rm --shm-size=1g -p 8080:8080 -p 8081:8081 -p 8082:8082 -e "AWS_NEURON_VISIBLE_DEVICES=ALL" -v $HOME/torchserve:/workspace ts-neuron-jdk17 Inside the container neuron-ls does not return anything.

rohithkrn avatar Jul 31 '22 04:07 rohithkrn

Codecov Report

Merging #1775 (a5b655d) into master (f20388b) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1775   +/-   ##
=======================================
  Coverage   45.28%   45.28%           
=======================================
  Files          64       64           
  Lines        2597     2597           
  Branches       60       60           
=======================================
  Hits         1176     1176           
  Misses       1421     1421           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Jul 31 '22 04:07 codecov[bot]

@rohithkrn please highlight deprecation message in README.md

lxning avatar Aug 02 '22 17:08 lxning

@rohithkrn please highlight deprecation message in README.md

@lxning Updated. Thanks

rohithkrn avatar Aug 02 '22 20:08 rohithkrn