pytorch icon indicating copy to clipboard operation
pytorch copied to clipboard

[Don't merge] [Kineto][submodule] Update kineto pin for XPU toggle feature

Open frost-intel opened this issue 10 months ago • 8 comments

Part of #154898 Update kineto submodule

Summary: We add the toggleCollectionDynamic functionality to XPUPTI in Kineto, so profiler can be enabled/disabled dynamically.

frost-intel avatar Jun 09 '25 21:06 frost-intel

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/155488

Note: Links to docs will display an error until the docs builds have been completed.

:white_check_mark: You can merge normally! (2 Unrelated Failures)

As of commit aeb1a2718094d25588ffc3abb236f2f7f6df39a8 with merge base 2625c70aecc6eced1dbe108279feab7509733bef (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Jun 09 '25 21:06 pytorch-bot[bot]

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

pytorch-bot[bot] avatar Jun 09 '25 21:06 pytorch-bot[bot]

To add the ciflow label ciflow/xpu please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

pytorch-bot[bot] avatar Jun 09 '25 21:06 pytorch-bot[bot]

@pytorchbot merge

frost-intel avatar Jun 13 '25 16:06 frost-intel

This PR updates submodules third_party/kineto

If those updates are intentional, please add "submodule" keyword to PR title/description.

pytorchmergebot avatar Jun 13 '25 16:06 pytorchmergebot

@sraikund16 Looks like pytorch/kineto#1092 uses localtime_r which isn't supported in VS22. Looks like the alternative localtime_s should be used?

frost-intel avatar Jun 13 '25 17:06 frost-intel

@frost-intel sorry about that I am drafting a PR to fix this

sraikund16 avatar Jun 13 '25 21:06 sraikund16

@sraikund16 , when the fixing pr is ready, pls. share the pr no here.

EikanWang avatar Jun 14 '25 04:06 EikanWang

@EikanWang sorry for the wait. Here is the PR: https://github.com/pytorch/kineto/pull/1104

sraikund16 avatar Jun 16 '25 17:06 sraikund16

@pytorchbot merge

guangyey avatar Jun 18 '25 00:06 guangyey

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging Check the merge workflow status here

pytorchmergebot avatar Jun 18 '25 00:06 pytorchmergebot

Merge failed

Reason: 3 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

pytorchmergebot avatar Jun 18 '25 02:06 pytorchmergebot

@pytorchbot rebase

guangyey avatar Jun 18 '25 05:06 guangyey

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot avatar Jun 18 '25 05:06 pytorchmergebot

Successfully rebased kineto_toggle onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout kineto_toggle && git pull --rebase)

pytorchmergebot avatar Jun 18 '25 05:06 pytorchmergebot

@pytorchbot merge

guangyey avatar Jun 18 '25 05:06 guangyey

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging Check the merge workflow status here

pytorchmergebot avatar Jun 18 '25 05:06 pytorchmergebot

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

pytorchmergebot avatar Jun 18 '25 06:06 pytorchmergebot

@pytorchbot merge

frost-intel avatar Jun 18 '25 12:06 frost-intel

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging Check the merge workflow status here

pytorchmergebot avatar Jun 18 '25 12:06 pytorchmergebot