audio icon indicating copy to clipboard operation
audio copied to clipboard

Published 20 hours ago • verified publisher icon pytorch

The ffmpeg integration shouldn't download linux binaries when the UNIX cmake variable is defined - it should issue proper messages for non-Linux UNIX systems

Open yurivict opened this issue 1 year ago • 3 comments

🐛 Describe the bug

The cmake code assumes here that UNIX implies linux, which isn't correct.

The code should check whether OS is Linux and only download linux binaries in that case. It should issue the relevant error message for other OSes.

*BSD systems are in the UNIX category but aren't able to run linux binaries.

Versions

2.x.

yurivict avatar Dec 13 '23 20:12 yurivict

Hi - Thanks for the report. I admit that I am mistakenly confusing these. Would you be able to provide a fix?

mthrok avatar Dec 14 '23 22:12 mthrok

Would you be able to provide a fix?

Sorry, I am only a port maintainer and don't have resources to provide a fix.

yurivict avatar Dec 14 '23 22:12 yurivict

Would you be able to provide a fix?

Sorry, I am only a port maintainer and don't have resources to provide a fix.

okay. I left the project and there aren't people following up. If this is causing some issue on some BSD ecosystem, let me know, I will try to find a time to fix.

mthrok avatar Dec 15 '23 00:12 mthrok