cpython icon indicating copy to clipboard operation
cpython copied to clipboard

Remove legacy TODOs from code.

Open jeremyhylton opened this issue 1 year ago • 3 comments

Bug report

Bug description:

I left a few TODOs in the compiler code from its early development. They are no longer relevant. For example, they comment on issues to consider that do not appear to have been a priority in years.

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs

  • gh-119223

jeremyhylton avatar May 20 '24 15:05 jeremyhylton

Out of curiosity, were those open items resolved or are they things we just don't care about anymore?

rhettinger avatar May 20 '24 17:05 rhettinger

We don't care about them anymore. They didn't seem urgent enough for anyone else to look at in the intervening years, and they don't seem critical either. How important is a realloc for an allocation in an arena that already has a fixed lifetime. Do you see a reason to think harder about it?

Jeremy

On Mon, May 20, 2024 at 1:32 PM Raymond Hettinger @.***> wrote:

Were those open items resolved or are they things we just don't care about anymore?

— Reply to this email directly, view it on GitHub https://github.com/python/cpython/issues/119219#issuecomment-2120893414, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHXXEJSSQKTMGDP74ELOLJDZDIXS3AVCNFSM6AAAAABH74J3ZOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRQHA4TGNBRGQ . You are receiving this because you were assigned.Message ID: @.***>

jeremyhylton avatar May 20 '24 18:05 jeremyhylton

I didn't have any objections. I was just curious. Please go ahead and do whatever makes sense to you. And thanks for all the work you've done in this arena ;-)

rhettinger avatar May 20 '24 21:05 rhettinger

Do you see a reason to think harder about it?

Perhaps nostalgia. We may all have higher ambitions when we were younger ... :)

(TODO entries are always a bit awkward though. Some TODOs I can solve quickly or within a reasonable time; others stay there for years, so perhaps this applies to the latter one as well, in which case it may be easier to just get rid of them rather than let them linger.)

rubyFeedback avatar May 22 '24 15:05 rubyFeedback