windrose icon indicating copy to clipboard operation
windrose copied to clipboard

Add option to specify radius steps

Open sspagnol opened this issue 4 years ago • 4 comments

Allow user to specify the steps at which radius circles and labels will be drawn as, and also sets the rmax value to be a multiple of rstep. So for example a call to plot_windrose(t, r, kind='bar', normed=True, blowto=False, rstep=5) will generate radii/labels of 5,10,15 etc. I don't know if this the best way to achieve this (that is should this be part of WindroseAxes constructor or just passed around in kwargs?), it just worked for my use case.

sspagnol avatar Sep 16 '21 02:09 sspagnol

Thanks for this PR but it's generaly a best practice to first open an issue to explain the problem. Then, create a PR which fix it (writing Closes #xyz where xyz is the number of issue)

s-celles avatar Sep 16 '21 05:09 s-celles

@sspagnol do you want to continue working in this? If so note that I rebased against our latest code tests. We need a test for this functionality and, if you can, add means for folks accessing it via the various plotting options.

ocefpaf avatar Sep 21 '22 16:09 ocefpaf

Would be great to have that as an option @ocefpaf !

simonweppe avatar Jan 17 '23 00:01 simonweppe

@simonweppe it seems that this PR is abandoned and needs some work/rebasing. Do you want to pick it up?

ocefpaf avatar Jun 12 '23 17:06 ocefpaf