3.6 is EOL so there's no reason to test on it.

3.8-dev and 3.9-dev are released versions, and are unnecessary.

I see no reason to test on both 3.7 and 3.8 PyPy nightly.

Codecov Report

Merging #2206 (32c2089) into master (fc98849) will decrease coverage by 0.03%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2206      +/-   ##
==========================================
- Coverage   99.51%   99.47%   -0.04%     
==========================================
  Files         114      114              
  Lines       14759    14759              
  Branches     2344     2344              
==========================================
- Hits        14687    14682       -5     
- Misses         47       49       +2     
- Partials       25       28       +3     

Impacted Files	Coverage Δ
trio/_core/_wakeup_socketpair.py	91.22% <0.00%> (-8.78%)	:arrow_down:
trio/socket.py	94.87% <0.00%> (-5.13%)	:arrow_down:
trio/_util.py	98.30% <0.00%> (-1.70%)	:arrow_down:
trio/tests/test_ssl.py	99.30% <0.00%> (+0.27%)	:arrow_up:
trio/_highlevel_ssl_helpers.py	100.00% <0.00%> (+11.76%)	:arrow_up:

Thank you for cleaning this up! Note we now have some uncovered lines for features that were only being exercised on 3.6. I think it would make the most sense to keep at least some tests for 3.6 until we actually remove 3.6 support, but I'm also OK with committing this as-is if you plan to then remove 3.6 support and remove the 3.6-supporting code that is no longer covered.

I've also updated the branch protection rules so that this is now mergeable.

if you plan to then remove 3.6 support and remove the 3.6-supporting code that is no longer covered.

Sorry for the delay, new years. Yes, this is what I plan to do ASAP.

Python 3.6 support was dropped in #2210.

Testing on dev versions allows catching issues before releases, but I agree that for already released versions it's less likely to be useful. I'm not sure why PyPy would not be worthy of tests on both 3.7 and 3.8?

I'm not sure why PyPy would not be worthy of tests on both 3.7 and 3.8?

This would drop for 3.7 nightly and 3.8 nightly, not regular 3.7 or 3.8 with the same justification as dropping -dev for older releases.

Right. In the past Nathaniel often raised PyPy bugs and the PyPy developers were (and still are) extremely reactive: fixes often show up in the nightly the next day. That happens less these days, though.

pretty sure this got changed like 10000 days ago so this is no longer relevant