poetry-core icon indicating copy to clipboard operation
poetry-core copied to clipboard

Fix issue with creating new projects on Windows

Open brycepg opened this issue 1 year ago • 2 comments
trafficstars

The previous code contained a bug where git couldn't reside in a relative subdirectory.

This change allows git to be installed in the user directory while avoiding git.exe from being injected via the current directory

For example the package manager scoop installes git.exe at %userprofile%/scoop/shims/git.exe which would previously cause poetry to fail.

I'd be also willing to write some code to enumerate %PATH% to find git.exe instead of using where.exe. That would fix an additional edge case of having the current directory in PATH with git.exe in it and it also being the cwd.

Resolves: python-poetry/poetry#7320

  • [ ] Added tests for changed code.
  • [x] Updated documentation for changed code.

brycepg avatar Dec 12 '23 03:12 brycepg

Do we want a regression test?

brycepg avatar Dec 12 '23 03:12 brycepg

Do we want a regression test?

We always want a test if it is feasible. 😄

radoering avatar Dec 15 '23 14:12 radoering