h11

h11 copied to clipboard

Should we support looser header name validation?

11

Closely related to #97. Prompted by https://github.com/encode/httpx/issues/1363#issuecomment-709706049 So, h11 currently has stricter-than-urllib3 rules on header name validation... ```python >>> import httpx >>> httpx.get("https://club.huawei.com/") Traceback (most recent call last): ... httpx.RemoteProtocolError:...

tomchristie

h11 fails on multiple targets where other HTTP clients work

5

Considering for example this snippet of code ``` def run(target): conn = h11.Connection(our_role=h11.CLIENT) sock = socket.create_connection((target, 80)) request = h11.Request(method="GET", target="/", headers=[("Host", target)]) data = conn.send(request) sock.sendall(data) data = sock.recv(2048)...

fbexiga

Robust handling of whitespace-malformed chunk encoding headers.

1

Prompted by https://github.com/encode/httpx/discussions/1735 When a server uses chunked encoding, but erroneously includes whitespace between the `` and the ``, a `RemoteProtocolError` is raised... ```pycon >>> import h11 >>> state =...

tomchristie

Inline the validate() function

2

This is based on #118, please look at the last commit only. (Sorry for the jungle of PRs, I can rebase them whichever way). --- It somewhat obscures the control...

bluetech

Speed up with Cython

3

On the premise of keeping Pure-Python h11, maybe `.pxd` + `Cython` can be used to improve performance? Related links: https://cython.readthedocs.io/en/stable/src/tutorial/pure.html#augmenting-pxd

abersheeran

Possibly we should allow HTTP/1.1 CONNECT requests without a Host: header

2

According to the spec, all HTTP/1.1 requests MUST have a `Host:` header. Currently h11 enforces this. @jab pointed me to this issue that go ran into in 2017 trying to...

njsmith

RemoteProtocolError: Illegal header line in response

3

The server I was trying to reach return every response with this line in header which raise RemoteProtocolError. I tried to forge a response with the header line, showing it...

yshen-ya

regression: event header can't be copied with normal Python syntax.

7

I have been using h11 for a while now. In my code, I made a copy of the headers like this: ```python headers = ev.headers[:] ``` That is the normal...

kdart-brt

Not running it on CI or anything, just for developers who want to run it locally. (If we do want to add it to CI and tox I'll happily add...

bluetech

Update header value validation to match WHAT-WG fetch spec

3

Header values are a mess. Supposedly they're defined by RFC 7230, but in fact it has a bug and its definition is obviously wrong. And, in practice, implementations are substantially...

njsmith