sir-lancebot

sir-lancebot copied to clipboard

Relevant Issues

Closes #861.

Description

• Moved all hacktoberfest commands into _cog.py
• Moved all hacktoberfest util functions into _utils.py
• Deleted the three hacktoberfest command files (since merged into _cog.py and _utils)
• Migrated all hacktoberfest commands to be under the Hacktoberfest cog and .hacktoberfest command (alias .hacktober)
• Renamed some commands (.hackstats --> .hacktoberfest stats, .hacktoberissues --> .hacktoberfest issues and .timeleft --> .hacktoberfest timeleft)
• Added a temp-fix to the already broken .hacktstats courtesy of @hedyhli. I believe they're planning to write a more permanent fix soon:tm:.

Did you:

• [x] Join the Python Discord Community?
• [x] Read all the comments in this template?
• [x] Ensure there is an issue open, or link relevant discord discussions?
• [x] Read and agree to the contributing guidelines?

Hey @TizzySaurus (for your PR description) the tempfix was for .hackstats not .hacktoberissues :)

@TizzySaurus is this PR only focused on migrating the code as-is and the restructuring or are you wanting to refactor the three commands as well? Many of Jason's suggestions are on (mostly 😃) copied original implementations (from #7, #46, #296, #466, #475, 047902d5, possibly more). IMO it should just copy the functions over for now plus many adjustments (which you've done) and then refactor them later in separate PRs (someone else could do this) since this is only about putting the three subcommands under a single hacktoberfest command.

Hey @TizzySaurus (for your PR description) the tempfix was for .hackstats not .hacktoberissues :)

Fixed, thanks :+1:

@TizzySaurus is this PR only focused on migrating the code as-is and the restructuring or are you wanting to refactor the three commands as well? Many of Jason's suggestions are on (mostly 😃) copied original implementations (from #7, #46, #296, #466, #475, 047902d, possibly more). IMO it should just copy the functions over for now plus many adjustments (which you've done) and then refactor them later in separate PRs (someone else could do this) since this is only about putting the three subcommands under a single hacktoberfest command.

I may redo certain easy parts, but I won't be completely refactoring the code. I agree with you that refactoring is outside the scope of this PR.

@Shivansh-007 @hedyhli Have just pushed #fca5a45 which fixes all the reviews I said I'd do :+1:

mm, @Bluenix2, you make a fair point, but we shouldn't block this merge over this small amount of git blame. It's fine to lose a little git blame in a refactor like this, and cleaning this up now after the fact is going to be quite annoying. I don't want this PR getting closed or abandoned over a technicality that might never have any real practical use for us, especially after all these wonderful people spent time reviewing it.

Hey @TizzySaurus, would you be able to continue working on this?

I'll be closing this PR due to staleness.

@hedyhli if you'd like to work on this, please ping me and I'll assign you, and the PR can be re-opened.