bot

bot copied to clipboard

Fixes BOT-1RG Fixes BOT-1RD

Closes #2002 Closes #2003

Changes:

• Add a better datetime converter that allows passing time in 12/24 hour format, the previous method of parsing start and end time is removed (8h, 16h, etc).
• If your modpings schedule is over and you even had a modpings off which got over in modpings off time period, the role won't be added to you as your schedule is over.
• Make modpings schedule message more verbose.

Fixes:

• Make 16 hours as the max off time i.e. make 8 hours the minimum on time.
• Since discord.py moved to timezone aware datetimes, the discord timestamp converter failed, therefore giving no confirmation message, this has now been fixed.
• add_roles is a method on a member object, thus calling add_roles on a user object would fail, this has now been fixed and it uses get_or_fetch_member utility function.

@mbaruh do we still want the 8h limit?

Added the do-not-merge because I accidentally approved instead of requesting changes.

Sorry about all the additions/deletions for requests reviews, I forgot how to GitHub for a minute.

This PR is now up for grabs.

Hi @kosayoda, are you still able to work on this?

Hi @kosayoda, are you still able to work on this?

Feel free to work on it!

@kosayoda Hello. What's your status on this PR?

Thanks!

I wanted to merge it as-is considering the source branch doesn't exist anymore, but it still contains bugs. This will need to be properly re-implemented.