cattrs icon indicating copy to clipboard operation
cattrs copied to clipboard

chore: improve annotations

Open aarnphm opened this issue 3 years ago • 2 comments

As I was working with cattrs recently, I notice there are some places where annotations are still missing.

Hopefully this PR address most of the popular API to be annotated.

aarnphm avatar Jul 07 '22 09:07 aarnphm

Codecov Report

Merging #288 (47fa388) into tin/copy (609b460) will decrease coverage by 0.05%. The diff coverage is 100.00%.

:exclamation: Current head 47fa388 differs from pull request most recent head ea26cec. Consider uploading reports for the commit ea26cec to get more accurate results

@@             Coverage Diff              @@
##           tin/copy     #288      +/-   ##
============================================
- Coverage     97.07%   97.01%   -0.06%     
============================================
  Files            16       16              
  Lines          1366     1340      -26     
============================================
- Hits           1326     1300      -26     
  Misses           40       40              
Impacted Files Coverage Δ
src/cattrs/converters.py 98.18% <100.00%> (-0.08%) :arrow_down:
src/cattrs/disambiguators.py 100.00% <100.00%> (ø)
src/cattrs/dispatch.py 100.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Jul 07 '22 09:07 codecov-commenter

cc @Tinche whenever you have time. This is just dx improvement, so it would be nice to include in 22.2. Otherwise there is no rush.

aarnphm avatar Jul 08 '22 19:07 aarnphm

I will close this now since I believe you also update annotations on the copy branch.

aarnphm avatar Sep 11 '22 21:09 aarnphm

Ah sorry, the copy branch took a lot longer than I was expecting. I don't think I have all of these though, if you reopen I will merge in.

Tinche avatar Sep 11 '22 22:09 Tinche

sg, let me check for any merge config.

aarnphm avatar Sep 12 '22 09:09 aarnphm