pytest icon indicating copy to clipboard operation
pytest copied to clipboard

no longer consider properties for fixtures of plugin objects (manages warning triggers)

Open RonnyPfannschmidt opened this issue 5 years ago • 9 comments

this one carries a bug-fix for for the fixture lookup that we might want to add in general as well as a stacklevel ix for the terminalwriter deprecation

if necessary i can extract

i'd like to add a unittest for the fixture parsing but i haven't approached the details yet

  • [ ] Include new tests or update existing tests when applicable.
  • [ ] Create a new changelog file in the changelog folder,

RonnyPfannschmidt avatar Mar 11 '20 14:03 RonnyPfannschmidt

deferring this pr as the "bugfix" is postentially a breaking change, the regendoc will have to have the warning

RonnyPfannschmidt avatar Mar 11 '20 21:03 RonnyPfannschmidt

@RonnyPfannschmidt should we close this in the spirit of clearing up the queue, to be tackled again in the future?

nicoddemus avatar Jun 09 '20 17:06 nicoddemus

I plan to sort it out before 6.0

RonnyPfannschmidt avatar Jun 09 '20 17:06 RonnyPfannschmidt

@nicoddemus i tried to add a test, but its looking like i can't trigger a warning message easily, there may be a missing part of warning coverage

RonnyPfannschmidt avatar Aug 02 '20 20:08 RonnyPfannschmidt

@RonnyPfannschmidt this might be stale after the recent regendoc fixes?

nicoddemus avatar Oct 05 '21 19:10 nicoddemus

@The-Compiler could this be something for 7.x?

RonnyPfannschmidt avatar Nov 16 '21 12:11 RonnyPfannschmidt

I'd honestly rather not ressurrect a 2 year old PR (hopefully) so close to the release - seems like a lot of potential to delay things further.

The-Compiler avatar Nov 16 '21 13:11 The-Compiler