swmmio

swmmio copied to clipboard

It looks like in swmmio.version_control, the create_combinations function doesn't correctly update the XSECTIONS part of the *.inp when a pipe already exists. The CONDUITS section is correctly updated (US/DS nodes, length, n, etc.).

I believe this case should be tagged as an "altered" model element, as noted here.

Can you create or share a very small baseline/alternative dummy model that reproduces this issue? I can use that to help debug this.

The baseline model contains two circular pipes (pipe names are the same). In the first alternative, one circular pipe is turned into a rectangular closed with one dimension. in the second alternative, the second pipe is also turned into a rectangular closes with a different dimension. test_files.zip