Loïck Piera

Results 43 comments of Loïck Piera

Hi @morawskim Do you have some time to finish this PR? It would be great to support a FFI-based notifier for linux environments.

Thanks for your work so far. About the tests, I understand it's not ideal to unit test the FFI part. Instead maybe we could just trigger the notifier for real...

I just rebased your PR in order to have PHPStan running in the CI. I also: - added a note in the Changelog - added a test `testSendNotificationWithAllOptions` that really...

Thanks a lot for your contribution @morawskim :pray:

Hi @adrenth I released v2 a few days ago so you might be the first to experience this issue. Sorry for that. I guess this is due to some class...

Sorry I did not find some time to dig this issue yet. @NicolasCARPi You're right, thanks for the suggestion, I just added a note in the [CHANGELOG.md](https://github.com/pyrech/composer-changelogs/blob/main/CHANGELOG.md) and the [GitHub...

Hello @adam-paterson, sorry to spam there, but could this PR be merged and released soon? :pray: Every new Slack app submission need to use these urls now :confused:

FYI, I opened #26 to discuss possibilities for the future of this package (maintaining our own fork is an option) :wink:

Closing for lack of feedback. Feel free to comment or reopen if you have more insights on this issue :slightly_smiling_face:

Hello @chaseconey, yes this PR should probably need only to regenerate the SDK from the updated spec. We would happily accept a PR to fix that. Thanks :slightly_smiling_face: