wheel icon indicating copy to clipboard operation
wheel copied to clipboard

Published 20 hours ago • verified publisher icon pypa

Support passing dist-info-dir to bdist_wheel

Open pelson opened this issue 1 year ago • 1 comments

Support passing dist-info-dir to bdist_wheel, enabling setuptools to handle prepare_metadata_for_build_wheel correctly as per PEP-517. Closes #611

I don't know what the implications of this if the metadata is wildly different - for example, within bdist_wheel there is a filename calculation - currently the metadata used for such calculations is from egg-info, not from the given dist-info. For my case, that was good enough, and I wasn't able to find a satisfying hook to disable egg-info calculation, and use that for distribution metadata. I would happily take advice on these.

pelson avatar Apr 24 '24 12:04 pelson

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 71.04%. Comparing base (0a4f40e) to head (cb140a6). Report is 12 commits behind head on main.

Files Patch % Lines
src/wheel/bdist_wheel.py 12.50% 7 Missing :warning:
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #612      +/-   ##
==========================================
- Coverage   71.28%   71.04%   -0.24%     
==========================================
  Files          13       13              
  Lines        1069     1074       +5     
==========================================
+ Hits          762      763       +1     
- Misses        307      311       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 24 '24 12:04 codecov[bot]

Closing since it is no longer in scope for wheel. (see https://github.com/pypa/wheel/issues/611#issuecomment-2125268578)

pelson avatar May 24 '24 11:05 pelson