pymc-marketing icon indicating copy to clipboard operation
pymc-marketing copied to clipboard

Published 20 hours ago • verified publisher icon pymc-labs

Allow specifying prior distribution in MMM models via config

Open ferrine opened this issue 2 years ago • 4 comments

https://github.com/pymc-labs/pymc-marketing/blob/d4feeeafad6f0299b115dac3582ad6d98bd8241f/pymc_marketing/mmm/delayed_saturated_mmm.py#L123-L126

Right now it is mixed logic of creating RV and registering it in the model. In principle that should be the only one method that returns already registered RV. That will allow a user to override prior specification

related to #267

ferrine avatar Jun 05 '23 11:06 ferrine

Thanks for the feedback! 👍 This was a change introduced in https://github.com/pymc-labs/pymc-marketing/pull/286 as an attempt to make the API somehow easy for the user. We will probably change it in https://github.com/pymc-labs/pymc-marketing/pull/295

juanitorduz avatar Jun 12 '23 18:06 juanitorduz

The channel prior was completely removed in #295 , as model_config from model_builder allows for customisation of every parameter

michaelraczycki avatar Jun 13 '23 09:06 michaelraczycki

We are still hard-coding things like it must be a HalfNormal prior.

We should allow arbitrary distributions like in the CLV models like here: https://github.com/pymc-labs/pymc-marketing/blob/0855e0139c88719d2c3e16f59b5655a1a0df4115/pymc_marketing/clv/models/beta_geo.py#L136

ricardoV94 avatar Aug 02 '23 10:08 ricardoV94

@ricardoV94 @twiecki Started working on this in PR #408

However, I encountered a minor issue and would like to get some help understanding how to solve it

MarkusSagen avatar Oct 23 '23 08:10 MarkusSagen

Closed with #397

williambdean avatar May 09 '24 15:05 williambdean