pymc

pymc copied to clipboard

Description

Related Issue

• [ ] Closes #
• [ ] Related to #

Checklist

• [x] Checked that the pre-commit linting/style checks pass
• [ ] Included tests that prove the fix is effective or that the new feature works
• [ ] Added necessary documentation (docstrings and/or example notebooks)
• [x] If you are a pro: each commit corresponds to a relevant logical change

Type of change

• [ ] New feature / enhancement
• [ ] Bug fix
• [ ] Documentation
• [x] Maintenance
• [ ] Other (please specify):

📚 Documentation preview 📚: https://pymc--7382.org.readthedocs.build/en/7382/

Jun 22 '24 02:06 Armavica

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.18%. Comparing base (1b67888) to head (0e984d0). Report is 91 commits behind head on main.

@@           Coverage Diff           @@
##             main    #7382   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files         103      103           
  Lines       17258    17258           
=======================================
  Hits        15909    15909           
  Misses       1349     1349           

Jun 22 '24 03:06 codecov[bot]

I took a very quick look. Very exciting, but there's a problem:

$ python -m build .
...
Successfully built pymc-0.0.0.tar.gz and pymc-0.0.0-py3-none-any.whl

It's picking up the version as 0.0.0. In contrast, on main:

Successfully built pymc-5.15.1+52.gc2c46a764.tar.gz and pymc-5.15.1+52.gc2c46a764-py3-none-any.whl

Jun 22 '24 22:06 maresb

@maresb You are right, it looks like versioneer is not ready yet to deal with builds configured from pyproject.toml. I moved the settings of mypy and versioneer to pyproject.toml but kept the build in setup.py, I think this is the most that we can do for now. I think it builds fine now.

Jul 10 '24 04:07 Armavica

It's great to get rid of versioneer.py, thanks @Armavica!!!

Jul 10 '24 14:07 maresb