Philipp Metzner
Philipp Metzner
Yes, exactly! I'd suggest two more things: - derive the existing Period class from ABC, instead of introducing a new DBPeriod class - provide docstrings (`"""Explanation of parameters, functionality, and...
If the docstring contain a detail that is specific to the tinydb implementation, this detail should remain in the TinyDbPeriod. The general parts can go into Period.
Did you install the dev tools as described in the section `Contributing` of the README? This way, formatting of the commit content and the commit message is automatically taken care...
Hej @GabeKutuzov, thanks for taking the initiative! How easy are Electron apps when it comes to testing, packaging, installing? If you don't mind we could think about the structure of...
Let me know how I can give you an insight of the package. Some parts should already been explained in the Readme (about the architecture) but there is no dedicated...
Did you have a look at the build log? You can do so by clicking 'Details'.
Ah that's tricky. Have a look at [this](https://stackoverflow.com/a/17345619/3865876) (I found it by googling for 'python test abstract class method'). This means you could do ``` Period.__abstractmethods__ = set() period =...
Can you rebase this onto master?
Can you also move the methods `_preprocess_entry`, `_remove_redundant_fields`, `_validate_entry`, and `_substitute_none_fields` and `_convert_fields` to Period? (sorry for blowing this up so much :))
I noticed that the change is still a bit trickier... I'd like to have the methods of `Period` run validation of passed parameters (e.g. for `add_entry()`), such that methods in...