python-udsoncan

python-udsoncan copied to clipboard

Hello @pylessard

I'm working on integrating Flexray support for UDS. This would need some minor changes to this packages and bigger changes on python-can-isotp:

• new Address, PDU, TransportLayer and Stack classes for Flexray

Do you think this changes could work? Or do you think a separate package for Flexray isotp would be better?

Hi @danielhrisca, I'm am not so familiar with flexray, but shouldn't it replace the Link Layer, meaning replace the pythoncan module? Is there a standard that explain how UDS over flexray should be done? Does it use ISOTP as well?

In any case, if the modification are major and interfaces are to be broken, I would maybe prioritize creating a new module for flexray. For this module, I expect a new Connection object only, so that is fine by me

Yes it is mostly the transport layer that needs adjusting.

In this package it is needed to remove this hard assert if other transports are to be supported https://github.com/pylessard/python-udsoncan/blob/master/udsoncan/connections.py#L448 with the PythonIsoToConnection class

Alright, if you can make something that doesn't break the interface, i'm all good. My requirements are to be backward compatible and keeping the unit test passing (unless a test needs an update for reasonable reason).

Thanks!

Should I close that?