cbor

cbor copied to clipboard

What is the motivation for this change? Without any other package in the top-level it doesn't make much sense to me to do this.

May 22 '20 09:05 stevenroose

The context is the discussion in #179. I have other changes locally which build on this, but they are perhaps more controversial, so I figured I'd make a fairly simple change which would help avoid merge conflicts and show incremental progress. But there's no interest...

May 23 '20 01:05 ahmedcharles

I don't see the idea of a workspace mentioned in #179 at all...

May 23 '20 16:05 stevenroose

It's implied by the mention of splitting the crate into a low level crate and one for just the serde integration.

May 24 '20 01:05 ahmedcharles

Please see my fork and branch. There is a workspace there, but there's no need to have this here as a stepping stone.

May 28 '20 23:05 hansl

I did look at your branch. It seems more like a rewrite than an incremental improvement. The primary reason I wanted to merge this is because I'd prefer reasoning about changes as incremental improvements rather than being forced to commit to one huge change all at once.

It seems like there isn't any interest in that, however.

May 29 '20 09:05 ahmedcharles