Pyfa icon indicating copy to clipboard operation
Pyfa copied to clipboard

Feature request, get skills for all pilots in the character editor

Open maxheise opened this issue 5 years ago • 5 comments

Hello,

I run 8 accounts, most have two or three pilots slots filled. If I do not refresh skills every so often for each and every pilot I get the error message "Error fetching skill information" for pilots, then I have to log in with the Eve SSO again and authorize Pyfa again to read my skills for each pilot with that error message.

Would it please be possible to add a button for "Get Skills for all pilots" that loops through all the pilots registered with Pyfa ? It would save me a tremedous amount of clicks.

Thanks Best regards

Bug Report

Expected behavior:

Actual behavior:

Detailed steps to reproduce:

Fits involved in EFT format (Edit > To Clipboard > EFT):

Release or development git branch? Please note the release version or commit hash:

Operating system and version (eg: Windows 10, OS X 10.9, OS X 10.11, Ubuntu 16.10):

Other relevant information:

maxheise avatar May 30 '20 14:05 maxheise

Damn, 8 accounts. 😋

I think this is doable and a decent idea. Not really sure where we would put it tho lol - maybe in the ESI characters window itself.

If I do not refresh skills every so often for each and every pilot I get the error message "Error fetching skill information" for pilots,

I'd like to know more about this... are you saying if you don't refresh your skills for a while, then it just fails the next time you try? Do you know roughly how long that waiting period is? The refresh token for ESI shouldn't have an expiration that I know of...

blitzmann avatar Jun 20 '20 03:06 blitzmann

I think character editor would be more appropriate place for this. As it was built, ESI management window is just for ESI authentication management.

So maybe like this:

  • extra button in character editor
  • main menu refresh button with some key modifiers (let's say alt, since alt is used as "batch action" key throughout pyfa)

But, would be cool if someone coded it :P

DarkFenX avatar Jun 20 '20 09:06 DarkFenX

main menu refresh button with some key modifiers (let's say alt, since alt is used as "batch action" key throughout pyfa)

I like this :)

Only reason I was kinda ehh about character editor is because it's always focused on the currently selected character. Having a button to do all would be weird, but it's all just semantics. 😁

blitzmann avatar Jun 20 '20 20:06 blitzmann

Well, that button also focuses on the currently selected character. I think it's all about presentation - if "refresh all" button is not in the row where per-character buttons are located, might be okay.

Could also add menu item into "character" menu as an option.

DarkFenX avatar Jun 22 '20 08:06 DarkFenX

Could also add menu item into "character" menu as an option.

I like this and the modifier for the refresh button on the main screen. 😁

I just don't really see a good place to put it on the character editor unless it's inline with those CRUD operation buttons image

blitzmann avatar Jun 22 '20 14:06 blitzmann