pandas-datareader icon indicating copy to clipboard operation
pandas-datareader copied to clipboard

Minor improvement in _read_url_as_StringIO method in basy.py

Open ilir-cecib opened this issue 4 years ago • 1 comments

Hello folks,

I would like to make the following change:

diff --git a/pandas_datareader/base.py b/pandas_datareader/base.py
index f60d266..f52993a 100644
--- a/pandas_datareader/base.py
+++ b/pandas_datareader/base.py
@@ -112,11 +112,11 @@ class _BaseReader(object):
             raise NotImplementedError(self._format)
         return self._read_lines(out)
 
-    def _read_url_as_StringIO(self, url, params=None):
+    def _read_url_as_StringIO(self, url, params=None, headers=None):
         """
         Open url (and retry)
         """
-        response = self._get_response(url, params=params)
+        response = self._get_response(url, params=params, headers=headers)
         text = self._sanitize_response(response)
         out = StringIO()
         if len(text) == 0:

I have the fix ready in my local branch.I would like to push it and open a PR. However, I don't have permissions to do so. I would like to make this change so one can pass headers in the url request when calling "_read_url_as_StringIO".

Greetings, Ilir

ilir-cecib avatar Aug 08 '21 07:08 ilir-cecib

Please submit a PR so we can review.

bashtage avatar Aug 12 '21 17:08 bashtage