pandas-datareader icon indicating copy to clipboard operation
pandas-datareader copied to clipboard

Feature/enable custom datareader

Open begoat opened this issue 4 years ago • 3 comments

  • [x] closes #895
  • [x] tests added / passed
  • [x] passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • [x] passes black --check pandas_datareader
  • [ ] added entry to docs/source/whatsnew/vLATEST.txt

begoat avatar Aug 02 '21 12:08 begoat

What does this bring that end users couldn't accomplish with subclassing?

bashtage avatar Aug 02 '21 12:08 bashtage

What does this bring that end users couldn't accomplish with subclassing?

Hi @bashtage

I came across this problem. https://github.com/pydata/pandas-datareader/issues/895 I cannot figure out one way to request https://stooq.com/q/d/l/?s=USDJPY

begoat avatar Aug 02 '21 13:08 begoat

Codecov Report

Merging #896 (a1e7a8e) into main (b1247d1) will decrease coverage by 1.60%. The diff coverage is 90.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #896      +/-   ##
==========================================
- Coverage   73.15%   71.54%   -1.61%     
==========================================
  Files          65       65              
  Lines        2932     2963      +31     
  Branches      315      316       +1     
==========================================
- Hits         2145     2120      -25     
- Misses        705      760      +55     
- Partials       82       83       +1     
Impacted Files Coverage Δ
pandas_datareader/__init__.py 40.90% <ø> (ø)
pandas_datareader/data.py 66.66% <78.57%> (+1.69%) :arrow_up:
pandas_datareader/tests/test_data.py 100.00% <100.00%> (ø)
pandas_datareader/tests/test_eurostat.py 40.47% <0.00%> (-59.53%) :arrow_down:
pandas_datareader/eurostat.py 61.29% <0.00%> (-25.81%) :arrow_down:
pandas_datareader/io/sdmx.py 80.00% <0.00%> (-11.43%) :arrow_down:
pandas_datareader/io/util.py 66.66% <0.00%> (-11.12%) :arrow_down:
pandas_datareader/tests/test_iex.py 94.44% <0.00%> (-5.56%) :arrow_down:
pandas_datareader/compat/__init__.py 86.84% <0.00%> (-2.64%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b1247d1...a1e7a8e. Read the comment docs.

codecov-commenter avatar Aug 02 '21 13:08 codecov-commenter