pandas-datareader icon indicating copy to clipboard operation
pandas-datareader copied to clipboard

added tiingo csv response serialisation options

Open tch opened this issue 5 years ago • 3 comments

  • [y] closes #821
  • [y] tests added / passed *
  • [y] passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • [y] passes black --check pandas_datareader
  • [y] added entry to docs/source/whatsnew/v.0.9.1.txt
  • Tests added as 'formats' fixture parametrisations ('json', 'csv') in test_tiingo.py

tch avatar Aug 31 '20 22:08 tch

Codecov Report

Merging #822 into master will decrease coverage by 1.39%. The diff coverage is 19.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #822      +/-   ##
==========================================
- Coverage   64.67%   63.27%   -1.40%     
==========================================
  Files          62       62              
  Lines        2848     2775      -73     
  Branches      305      306       +1     
==========================================
- Hits         1842     1756      -86     
- Misses        932      945      +13     
  Partials       74       74              
Impacted Files Coverage Δ
pandas_datareader/tiingo.py 25.66% <7.40%> (-8.00%) :arrow_down:
pandas_datareader/tests/test_tiingo.py 38.00% <42.85%> (-4.31%) :arrow_down:
pandas_datareader/base.py 84.09% <100.00%> (-0.47%) :arrow_down:
pandas_datareader/av/time_series.py 30.23% <0.00%> (-9.77%) :arrow_down:
pandas_datareader/tests/av/test_av_forex.py 50.00% <0.00%> (-8.07%) :arrow_down:
pandas_datareader/av/quotes.py 28.57% <0.00%> (-5.64%) :arrow_down:
pandas_datareader/av/forex.py 22.72% <0.00%> (-4.94%) :arrow_down:
pandas_datareader/tests/test_moex.py 73.91% <0.00%> (-4.35%) :arrow_down:
pandas_datareader/tests/av/test_av_quotes.py 50.00% <0.00%> (-4.17%) :arrow_down:
pandas_datareader/tests/av/test_av_sector.py 62.50% <0.00%> (-4.17%) :arrow_down:
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d2ef4e6...1ffeeb1. Read the comment docs.

codecov-commenter avatar Aug 31 '20 22:08 codecov-commenter

Regarding testing. The API has free plan - it would be possible to setup dedicated key for automated tests ( https://api.tiingo.com/about/pricing )

tch avatar Sep 01 '20 11:09 tch

Hi, Just a quick ping to check whether I am missing anything for this PR to get it merged for a release?

tch avatar Sep 10 '20 12:09 tch