pandas-datareader

pandas-datareader copied to clipboard

• Binance Exchange is a exchange for crypto currencies.
• It provides a API for users to retrieve data
• We can add support for this which would increase the usability of this module

@rohitjain00 that would be nice for sure!

base.py is the base class above which all the APIs for different source of data needed to be implemented?

@rohitjain00 https://github.com/binance-exchange/binance-official-api-docs/blob/master/rest-api.md

maybe you could use https://github.com/pydata/pandas-datareader/blob/master/pandas_datareader/eurostat.py as a starting point

Thanks for the help. I have already started working on it. I am facing an issue with the implementation I want user to provide me with Interval of the data required which is mandatory for the API. As per the DataReader method I can only take input with provided parameters. Is there any way to take custom input from the user and to expose a ENUM class to the user to pass intervals in them.

Also is there any slack/gitter channel for the help.

I'm not sure whet intervals you are referring to above. Maybe

Kline/Candlestick chart intervals:
m -> minutes; h -> hours; d -> days; w -> weeks; M -> months

Providers can introduce additional parameters. As an example review https://github.com/pydata/pandas-datareader/blob/master/pandas_datareader/av/time_series.py#L46

@gliptak can you review my code for this and provide me with feedback on how to improve the implementation. I still need to write docs and tests for this.

Here are proposed changes

@rohitjain00 looks like a good start.

are these the right values for Binance API https://github.com/pydata/pandas-datareader/compare/master...rohitjain00:binance#diff-858c99a95d8c111146c613999fcc7443R13 ?

please add test(s) and submit as a PR (to review Travis results and so committers can comment)

I have written tests for checking the dimensions and columns of the response. I am relatively new to writing tests can you suggest me what more checks to add in this.

Here are the changes Here is the test file

@rohitjain00 please start a PR https://github.com/pydata/pandas-datareader should show your branch referenced above

That is a good initial test. Maybe you could also add a test to check open/high/low/close for a particular date

For now I will start a PR for the above branch and keep updating new test cases and improvements.

As much as I would love to see this, the CCXT package supports practically every crypto exchange on the market. Would it make more sense to integrate with it directly or am I off my base here?

any updates on this ? Is it available ?

It was available when I created a CR but @dahifi recommended something better and I did not had bandwidth to implement it. So if anyone else is willing to take on this task it would be awesome.