pydantic-core icon indicating copy to clipboard operation
pydantic-core copied to clipboard

Add full type to validation error

Open derlih opened this issue 1 year ago • 4 comments

Add full type to validation error

Full type name added to the validation error.

Related issue number

fix #7911

Checklist

  • [x] Unit tests for the changes exist
  • [ ] Documentation reflects the changes where applicable
  • [ ] Pydantic tests pass with this pydantic-core (except for expected changes)
  • [x] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @adriangb

derlih avatar Apr 19 '24 21:04 derlih

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes are missing coverage. Please review.

Files Patch % Lines
src/tools.rs 54.54% 5 Missing :warning:

:loudspeaker: Thoughts on this report? Let us know!

codecov[bot] avatar Apr 19 '24 21:04 codecov[bot]

CodSpeed Performance Report

Merging #1276 will not alter performance

Comparing derlih:7911-validation-error-full-type (2ead444) with main (91c3541)

Summary

✅ 155 untouched benchmarks

codspeed-hq[bot] avatar Apr 19 '24 21:04 codspeed-hq[bot]

please review

derlih avatar Apr 20 '24 05:04 derlih

Thanks for this! I think we have a related feature discussion in https://github.com/PyO3/pyo3/pull/4056 - so I might just see what the outcome of that PR is before merging this one.

davidhewitt avatar Apr 22 '24 10:04 davidhewitt

Superseded by #1342, which uses the PyO3 implementation .fully_qualified_name() to get the type name. Thanks for this PR!

davidhewitt avatar Jun 25 '24 09:06 davidhewitt