pydantic-core

pydantic-core copied to clipboard

Change Summary

Based on comment https://github.com/pydantic/pydantic/issues/7186#issuecomment-1912192517 implemented omit_trailing_slash feature for PyUrl crate.

Related issue number

https://github.com/pydantic/pydantic/issues/7186

Checklist

• [x] Unit tests for the changes exist
• [x] Documentation reflects the changes where applicable
• [x] Pydantic tests pass with this pydantic-core (except for expected changes)
• [x] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @dmontagu

Mar 06 '24 09:03 tworedz

please review

Mar 06 '24 09:03 tworedz

Codecov Report

Merging #1218 (ca4b802) into main (ab503cb) will increase coverage by 0.08%. Report is 28 commits behind head on main. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1218      +/-   ##
==========================================
+ Coverage   90.21%   90.29%   +0.08%     
==========================================
  Files         106      106              
  Lines       16339    16423      +84     
  Branches       36       39       +3     
==========================================
+ Hits        14740    14829      +89     
+ Misses       1592     1575      -17     
- Partials        7       19      +12     

Mar 06 '24 09:03 codecov[bot]

CodSpeed Performance Report

Merging #1218 will not alter performance

_{Comparing tworedz:omit-trailing-slash (ca4b802) with main (c6301fe)}

Summary

✅ 148 untouched benchmarks

Mar 06 '24 10:03 codspeed-hq[bot]

Prior art: #1173. Is there a reason why this route should be seen as preferred to the broader suite of normalization bugs which that PR discussed (and ultimately decided we need fixes in rust-url to resolve)?

Mar 06 '24 10:03 davidhewitt

Prior art: #1173. Is there a reason why this route should be seen as preferred to the broader suite of normalization bugs which that PR discussed (and ultimately decided we need fixes in rust-url to resolve)?

In my humble opinion, there seem to be two related yet slightly different issues that we are trying to tackle. The #1173 PR is aimed at fixing the broken Url.build feature, as discussed earlier, and this should be addressed through modifications to rust-url.

Modifying the behavior of rust-url to accommodate URL processing, a functionality relied upon by all users of this crate, appears to be quite challenging. However, from the perspective of pydantic, this was the previous behavior that many projects accepted and utilized, and they aim to continue using it in v2.

What are your thoughts on this?

Mar 06 '24 11:03 tworedz

Let me reflect on this. My instinct is that this is still a rust-url issue, but I may need to prompt discussion upstream.

Mar 06 '24 12:03 davidhewitt

Thanks!

Mar 06 '24 12:03 tworedz

(Just to set expectations, I've set myself a reminder to explore this next week, when I expect to be also picking up #1085 again. Please ping me if this PR falls off my radar.)

Mar 06 '24 12:03 davidhewitt

Great! I'll glad to any response)

Mar 06 '24 12:03 tworedz

@davidhewitt Hey, could you please provide updates?)

Mar 15 '24 05:03 tworedz

I have been thinking about this a bit. I would like to avoid the config flag if we can. It seems to me that it's a problem that the URL does not round-trip, and this seems to be a problem of rust-url, which apparently follows the WHATWG URL spec, so I think that first I want to understand if the spec expects this behaviour, or it's a rust-url bug.

Mar 19 '24 10:03 davidhewitt

@davidhewitt, what do next steps look like here? Do we still plan on attempting to implement this?

Aug 17 '24 17:08 sydney-runkle