puppetlabs_spec_helper icon indicating copy to clipboard operation
puppetlabs_spec_helper copied to clipboard

Add rspec-github integration

Open ekohl opened this issue 3 years ago • 1 comments

This adds rspec-github as a dependency and at runtime it is optionally configured. The detection is the same as for Rubocop.

In https://github.com/voxpupuli/puppet-example/pull/22 I've showcased that this works: Screen Shot 2022-08-05 at 15 44 53

ekohl avatar Aug 05 '22 13:08 ekohl

Codecov Report

Merging #353 (af049ed) into main (cbad6f4) will decrease coverage by 0.79%. The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #353      +/-   ##
==========================================
- Coverage   43.28%   42.49%   -0.80%     
==========================================
  Files          11       10       -1     
  Lines         841      779      -62     
==========================================
- Hits          364      331      -33     
+ Misses        477      448      -29     
Impacted Files Coverage Δ
lib/puppetlabs_spec_helper/module_spec_helper.rb 0.00% <0.00%> (ø)
lib/puppetlabs_spec_helper/puppet_spec_helper.rb 65.51% <ø> (ø)
lib/puppetlabs_spec_helper/tasks/fixtures.rb 38.36% <ø> (ø)
lib/puppetlabs_spec_helper/rake_tasks.rb 42.04% <54.16%> (+0.57%) :arrow_up:
...bs_spec_helper/puppetlabs_spec/puppet_internals.rb 92.50% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Aug 05 '22 13:08 codecov-commenter

@ekohl I love this.

There are going to be a few more updates to the repo so this PR will need rebasing soon.. (unless you want to keep rebasing as we merge changes).

chelnak avatar Oct 24 '22 10:10 chelnak

@ekohl @bastelfreak The bulk of work has been merged to main now. Would it be possible for one of you to rebase this and resolve the conflict? Once that is sorted i'll get it merged & it will be in the next release.

chelnak avatar Oct 24 '22 16:10 chelnak