puppetlabs-postgresql

puppetlabs-postgresql copied to clipboard

There was an issue using postgresql::server::grant::onlyif_exists = true and specifying a schema postgresql::server::grant::object_name = ['myschema', 'mytable'] as the onlyif check was including the schema in the query in pg_* views.

postgresql::server::grant is a type

that may have no external impact to Forge modules.

This module is declared in 70 of 578 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

All committers have signed the CLA.

This PR has been marked as stale because it has been open for a while and has had no recent activity. If this PR is still important to you please drop a comment below and we will add this to our backlog to complete. Otherwise, it will be closed in 7 days.

Hello, yes this is still important as it fixes an issue. Thanks for reviewing !

postgresql::server::grant is a type

Breaking changes to this file WILL impact these 2 modules (exact match):

• deric-pgprobackup
• landcareresearch-ckan

Breaking changes to this file MAY impact these 1 modules (near match):

• puppetfinland-patchwork

This module is declared in 70 of 579 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

The EL 8 test failures can be ignored (they also fail without this PR), but I do wonder if you can come up with a test that shows the new behavior.

Hello! 👋

This pull request has been open for a while and has had no recent activity. We've labelled it with attention-needed so that we can get a clear view of which PRs need our attention.

If you are waiting on a response from us we will try and address your comments on a future Community Day.

Alternatively, if it is no longer relevant to you please close the PR with a comment.

Please note that if a pull request receives no update for 7 after it has been labelled, it will be closed. We are always happy to re-open pull request if they have been closed in error.

Hello, thanks for the note. I just added a test on this specific case. Thank you for reviewing.

@vaol Thanks for putting in the work :)

@vaol Thanks for putting in the work :)