puppetlabs-kubernetes

puppetlabs-kubernetes copied to clipboard

add feature kube_proxy_enable add feature maintenance_new_nodes add feature containerd_sandbox_image

All committers have signed the CLA.

kubernetes::config::kubeadm is a class

that may have no external impact to Forge modules.

kubernetes::config::worker is a class

that may have no external impact to Forge modules.

kubernetes is a class

Breaking changes to this file MAY impact these 5 modules (near match):

• jetstack-kubernetes_addons
• jetstack-tarmak
• jetstack-fluent_bit
• jetstack-prometheus
• jetstack-calico

kubernetes::packages is a class

that may have no external impact to Forge modules.

kubernetes::service is a class

that may have no external impact to Forge modules.

This module is declared in 0 of 579 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

I suggest instead of maintenance_new_nodes use something like node_registation_tains (Array) to have the ability to use other taints too.

@ArsenyBelorukov ok, i'll fix it today. What to do with tests, they are broken in the master branch?

@BaronMsk I don't know about tests, sorry. I am just in the adoption process of this module.

I have another question about your PR: you use kube_proxy_enable not to add kubeproxy.config to kubeadm config, but do not set the skipping the phase addon/kube-proxy. How should it work?

kube-proxy is not a phase, it's an addon. kubeadm will only show a warning and continue Notice: /Stage[main]/Kubernetes::Cluster_roles/Kubernetes::Kubeadm_join[k8s-test-worker-dtln-3]/Exec[kubeadm join]/returns: W1027 14:23:31.375960 3628 configset.go:78] Warning: No kubeproxy.config.k8s.io/v1alpha1 config is loaded. Continuing without it: configmaps "kube-proxy" is forbidden: User "system:bootstrap:e4247f" cannot get resource "configmaps" in API group "" in the namespace "kube-system"

@BaronMsk Deploy kube-proxy is performed in the addon/kube-proxy phase. Without kubeproxy.config it is deployed anyway:

# grep kind /etc/kubernetes/config.yaml
kind: InitConfiguration
kind: ClusterConfiguration
# kubeadm init --config '/etc/kubernetes/config.yaml'
...
[addons] Applied essential addon: kube-proxy
...
# kubectl -n kube-system get daemonsets
NAME         DESIRED   CURRENT   READY   UP-TO-DATE   AVAILABLE   NODE SELECTOR            AGE
kube-proxy   1         1         1       1            1           kubernetes.io/os=linux   60s

yes I understand what you mean... I think kubeadm doesn't allow to disable addons ((((. The problem is that if do not remove kube-proxy from config, then when updating kubeadm, it will deploy it again

I'll try to disable this addon --skip-phases=addon/kube-proxy

Hi @BaronMsk . Thank you for your contribution. In order for us to best address your PR, we'd appreciate if you could add a more descriptive title and a more detailed description outlining the context of the problem you're addressing and the steps you took to make the necessary changes.

We have a CONTRIBUTION.md in each module repo linking to this which outlines instructions on how to best contribute to Puppet modules.

Thanks

I am closing this PR. I will continue to work in other PRs