puppetlabs-apache

puppetlabs-apache copied to clipboard

Describe the Bug

In https://github.com/puppetlabs/puppetlabs-apache/pull/2442 the forensics module was added to the relatively small set of default installed plugins but there wasn't clear rational given why. The "hack" needed to enable it is the same as for all plugins, e.g.

class { 'apache::mod::forensics': }
# or via hiera defined classes lookup('classes', Array[String], 'unique').include
classes:
  - apache::mod::forensics

As the forensics module does not appear to be a particular commonly used module it should not be in the default set unconditionally: https://github.com/puppetlabs/puppetlabs-apache/blob/main/manifests/default_mods.pp#L123

If I am mistaken in this assumption please instead add a clearer rational to why it is added as a source code comment to avoid confusion in the future.

Expected Behavior

The default configuration installs the minimal needed set of plugin or at least allow disabling this optional one.